Athens: Add catalog method to azure storage

Created on 13 Dec 2018  路  21Comments  路  Source: gomods/athens

Is your feature request related to a problem? Please describe.
With #955 a new catalog endpoint has been introduced.

961 was opened to add missing storages and mongo is on its way to be merged.

This issue is for implementing the cataloger interface in Azure

Describe the solution you'd like
Implement the cataloger in azure.

good first issue storage

Most helpful comment

I can take this up 馃槃

All 21 comments

I can take this up 馃槃

@scriptonist How is you progress with this one? I can take it if you changed your mind or doesn't have enough time.

@scriptonist ping ping. any progress here? if you're out of time let's allow @Zyqsempai to continue

Extremely Sorry for the delay @Zyqsempai @michalpristas, got caught up at work. @Zyqsempai please take this up because It will be difficult for me to find time in the next two weeks.

@scriptonist No worries. I will take care of it from here.

@scriptonist thanks for the reply. take care ;-)

@Zyqsempai @michalpristas I'm new here. It would be great if I was allowed to take this up :+1:
Also, can you guys guide me as I'm not familiar with the code base :smile:

@jamesgeorge007 There is another issue that has not been claimed so far, can you please let @Zyqsempai take this while you work on the other one as he had already claimed it?

@manugupt1 fine :+1:

Guys, any idea on: how we can test azure storage? We don't have any test for it currently,

@Zyqsempai we have an ongoing PR that will add azurite so we can test against it, just like we use minio to test s3.

@marpio Cool, can you reference this issue in that PR to monitor status. Coz i am kind of blocked here.

@Zyqsempai sorry for the delay on this. https://github.com/gomods/athens/pull/821 adds azurite for tetsting. I asked @chriscoffee if he's available to finish it. if he's busy I'll take it up so you can continue

@arschles Great. looking forward to finish this one.

@Zyqsempai now that #821 is merged, do you have everything you need? I know that there aren't any azure tests at all yet, so if you'd like we can work together there. Let me know what you think, and thanks for waiting 馃榿

@arschles Great news, I need to check what the status of my PR, it's been a while since I worked on it. I will come back to you with updates.

thanks @Zyqsempai! 鉂わ笍

I would like to work on this. Let me know if I can take this up:)

Please do @gowdabas ! 馃帀
Also while you're at it, take a look at https://github.com/gomods/athens/issues/1186
We are considering using the same format as https://index.golang.org/ for the V2 of our catalog endpoint.

Sure, thanks for pointing that out , @marpio .

FYI, if anyone needs to test this, you can use https://github.com/Azure/Azurite for local testing

Was this page helpful?
0 / 5 - 0 ratings

Related issues

robjloranger picture robjloranger  路  4Comments

marpio picture marpio  路  4Comments

komuw picture komuw  路  3Comments

marpio picture marpio  路  3Comments

komuw picture komuw  路  3Comments