Athens: Vote: Should we use : latest tag on docker hub

Created on 8 Dec 2018  路  8Comments  路  Source: gomods/athens

At the moment the script that's pushing to docker hub sets :latest tag on every release:
https://github.com/gomods/athens/blob/5ab820de96fa69c1a9e69119d9ca9e171b33667f/scripts/push-docker-images.sh#L25
There are pros and cons of using :latest and we should decide if we want to use it.

ccd vote

Most helpful comment

Yes, we should use :latest

All 8 comments

Yes, we should use :latest

No, we should not.

My take is that latest is ok as long as we release frequently and the gap between master and release isn't big.

I think we opened this one on slack/dev meeting. Discussing exactly that the problem we encountered was our fault and we should stick with common/best practices.

cc: @carolynvs @arschles

@michalpristas yes, but this issue came again yesterday on slack because apparently the push script didn't create the latest tag for v0.2.0 and so people getting errors when they pull with latest or without a tag.
We should choose one option and stick to it.

@marpio I opened #989 to fix the script to push latest on pushes to master and stable on tag releases. We can merge if we vote yes on this issue 馃憤

@marpio @michalpristas @carolynvs I think we can close this because of the same reason we discussed https://github.com/gomods/athens/pull/989#issuecomment-454546871, what do you think?

:+1:

Was this page helpful?
0 / 5 - 0 ratings