Athens: Add Prometheus service to Athens docker-compose

Created on 6 Dec 2018  路  5Comments  路  Source: gomods/athens

Is your feature request related to a problem? Please describe.
As we support metrics export to prometheus (#816) we could add it as a service to our docker-compose

Describe the solution you'd like

There should be configured prometheus service in Athens docker-compose that will be listening on Athens metrics endpoint

Additional context
https://hub.docker.com/r/prom/prometheus/
https://prometheus.io/docs/prometheus/latest/configuration/configuration/

dev ux good first issue

Most helpful comment

Can I give this a shot?

All 5 comments

Can I give this a shot?

Sure, go ahead!

Sorry about the delay. I was busy with school work. I added a Prometheus service to the docker-compose file but I made a lot of hacky assumptions when writing the configuration file and updating the docker-compose file. Should I create a PR so that you guys can critic?

sure @vaibhavjayaraman feel free to raise a PR and comment places where you need input from somebody, or something is unclear

Cool. I raised a PR and commented on lines that I had immediate issues with.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

opinionsDazzle picture opinionsDazzle  路  4Comments

Haiyung picture Haiyung  路  3Comments

komuw picture komuw  路  3Comments

fedepaol picture fedepaol  路  4Comments

robjloranger picture robjloranger  路  4Comments