Athens: Should we add more to the CODEOWNERS file?
The current CODEOWNERS file has only one line - everything is "owned" by @gomods/maintainers. We have a bigger community now, and a super different codebase, than we did when we committed that file.
Should we add more lines to the file so that we have different directories specialized to particular people/teams?
arschles
All 5 comments
i would go with teams, which seems easier to manage. dont need to have PR with changes if you want to add somebody.
was thinking about package domain teams:
- storage
- api (incl middlewares)
- communication flow
- security
- test
- ops (tracing, config)
just from top of my head
michalpristas
on 24 Oct 2018
@michalpristas would those be represented by wildcards in the codeowners file? Also, would we create Github teams for each of those categories?
arschles
on 9 Nov 2018
I think we have to create teams in GitHub to assign them to portions of the codebase. I don't believe you can assign more than one person or entity as an owner, one @something etc.
robjloranger
on 10 Nov 2018
@arschlesI meant in a way how @robjloranger described
michalpristas
on 12 Nov 2018
I like the initial ideas @michalpristas had here https://github.com/gomods/athens/issues/806#issuecomment-432524651
We can always adjust as we move along. I'm happy to create the teams today if that's somewhere we'd like to start.
robjloranger
on 12 Nov 2018
Related issues
marpio
路
4Comments
leitzler
路
3Comments
robjloranger
路
4Comments
arschles
路
3Comments
arschles
路
4Comments
Most helpful comment
i would go with teams, which seems easier to manage. dont need to have PR with changes if you want to add somebody.
was thinking about package domain teams:
just from top of my head