Athens: Can we somehow auto-merge PRs?

[arschles]

We currently have some criteria that GH enforces for when we can merge PRs:

• Our 3 status checks: netlify builds, travis-CI builds and the WIP bot (see #792 for details on the bot)
• we need 1 reviewer to sign off

Even after all of our criteria have been met, a maintainer still has to go and manually merge the PR, and that's just extra waiting and work that would be great if we didn't have to do. I'm not sure if there's a service out there that can do auto-merges for us. Otherwise, we could build something or wait for GH Actions to be enabled on our organization

[robjloranger]

I think the only problem is how to differentiate between reviews that should have a longer period so more people can review. Really big changes and the like.

[arschles]

yep absolutely. I haven't thought this through much, maybe in the comments a reviewer can say something like add @someone to indicate that there needs to be another reviewer?

[robjloranger]

I was thinking that way as well, or maybe on bigger PRs reviewers should only comment until they are certain they should be the final approval. Like if I see four people have commented approval and I review plus ensure all comments were addressed, then I can approve which triggers the auto merge.

Or something along those lines.

[michalpristas]

I think @carolynvs mentioned they have a good process in Helm(?) with one approver writing LGTM another one Approved and it gets merged. Maybe we can think of something like this. Don't know how much their solution is configurable but might be worth to look into that.

[robjloranger]

I like that, require x LGTMs and then the next approval can merge.

[arschles]

some things that could help automate:

• mergeable
• https://github.com/fastlane/issue-bot
• https://github.com/bobvanderlinden/probot-auto-merge (this one looks most promising)
  
  
  
  • https://github.com/apps/probot-auto-merge
  
  

[marpio]

Mergable looks awesome!

[robjloranger]

:+1: for mergeable, it looks perfect

[michalpristas]

mergable looks awesome 👍

[chriscoffee]

+1 for mergeable. It clearly has the coolest logo which is the biggest factor in my choice.

[robjloranger]

I think once we get this set up it should also block do-not-merge and frozen (if we add that tag)

[arschles]

Closing because we’re doing pretty well with reviews and manually merging.