Athens: Specify a list of endpoints that should not be traced

[manugupt1]

Describe the bug
Currently, there is no way to filter out specific endpoints to our traces in our middleware
It will be nice to have a way to filter those out

Example
/healthz endpoint is hit a lot of times and is definitely not useful for tracing functionality

[marwan-at-work]

@manugupt1 OpenCensus v0.15.0 explicitly skips /healthz -- how were you getting them?

[manugupt1]

Did not realize that. I looked at ochttp plugin and they did it, so I thought it will be a good idea anyway. I did not see on the trace though.

Cheers
Manu

---

From: Marwan Sulaiman [e-mail]
Sent: Wednesday, September 19, 2018 11:30:23 PM
To: gomods/athens
Cc: Manu Gupta; Mention
Subject: Re: [gomods/athens] Specify a list of endpoints that should not be traced (#654)

@manugupt1https://github.com/manugupt1 OpenCensus v0.15.0 explicitly skips /healthz -- how were you getting them?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/gomods/athens/issues/654#issuecomment-423028685, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAYLj2zO1ezrCzkG_olUcNro7YrLY3aDks5ucwvPgaJpZM4WmeaT.

[manugupt1]

I am closing this issue as we the healthz endpoint is automatically excluded and I can't think of anything else

[michalpristas]

just a side note that it is common to use /healtz for liveness checks and /ready for readiness, we will cross that bridge when we get to it though

[chriscoffee]

just a side note that it is common to use /healtz for liveness checks and /ready for readiness, we will cross that bridge when we get to it though

Just a quick addition to that, if we're going with /healthz we should probably also do /readyz. It's a Google practice to avoid collisions