Athens: Stream zip up to AWS S3 storage

Created on 3 Jul 2018  路  6Comments  路  Source: gomods/athens

PR #200 changes the storage.Saver interface so that it accepts zip as io.Reader but the AWS S3 storage impl. uses ioutil.ReadAll to get a byte slice which gets then uploaded.

This could probably help:
https://docs.aws.amazon.com/sdk-for-go/api/service/s3/s3manager/#Uploader

picture marpio

Most helpful comment

I talked to Michal. I'll take this one.

picture marpio on 10 Jul 2018
🎉1 👍1

All 6 comments

@marpio now that #200 is merged, is this issue completed?

arschles picture arschles on 9 Jul 2018

Not yet. The s3 and gcp storages still pass a byte slice to their clients.

robjloranger picture robjloranger on 9 Jul 2018
👍1

@robjloranger gcp is using Io.reader

marpio picture marpio on 10 Jul 2018

Oh nice 馃槉, I missed the io copy

robjloranger picture robjloranger on 10 Jul 2018

I talked to Michal. I'll take this one.

marpio picture marpio on 10 Jul 2018
🎉1 👍1

assigned to you @marpio

michalpristas picture michalpristas on 10 Jul 2018
Was this page helpful?
0 / 5 - 0 ratings

Related issues

arschles picture arschles  路  3Comments
Haiyung picture Haiyung  路  3Comments
robjloranger picture robjloranger  路  4Comments
arschles picture arschles  路  4Comments
leitzler picture leitzler  路  3Comments