Athens: [Meta] Implement drivers for the pointer registry

[arschles]

https://github.com/gomods/athens/pull/144 added a "pointer registry" interface for use with the proxy (confusingly called "Athens" at the moment). Athens uses the pointers to store the last event log entry that it has fetched from Olympus, and of course it needs to persist them somewhere.

Right now there is only an interface, and we need implementations:

• RDBMS's (the ones that pop supports)
• Mongo (done)
• File (done)
• Memory (for dev purposes)
  
  
  
  • need issue for this
  
  

This issue is "meta", meaning nobody needs to submit one PR that implements all the drivers.

[robjloranger]

Looking at the current interface, there is only a look up method. Should there be a set or update method as well? There is now a PR for adding a method to set the pointer in the registry. #148

[robjloranger]

Mongo is complete

[arschles]

@robjloranger you are rad 🙌

checked off mongo in the OP

[robjloranger]

I am starting on the FS driver.

[lcd1232]

I am starting RDBMS driver

[arschles]

👍

On Thu, Jun 7, 2018 at 09:54 lcd1232 [e-mail] wrote:

I am starting RDBMS driver

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/gomods/athens/issues/146#issuecomment-395491383, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAEU0eRWUlGn8iOE3h7VCfiJ1Jl4OQ8Tks5t6VrSgaJpZM4UViTx
.

[michalpristas]

just pushed FS by @robjloranger

[robjloranger]

@lcd1232 how is the RDBMS driver coming?

[lcd1232]

@robjloranger 1-2 days

[robjloranger]

Awesome, no rush @lcd1232. just wanted to touch base and see if you were still working on it.

[sadlil]

@lcd1232 Is the RDBMS driver still open? Or I can try to create one? if yes, @robjloranger @arschles any concern using gorm to implement a generic driver? So caller needs to import the DB specific driver and pass as configurations? Or implementations needs to be specifics?

@arschles any other driver in mind? may be redis or else?

[michalpristas]

@sadlil we let RDBMS go. and wont support that - perf

[lcd1232]

@sadlil yes you can do it

[arschles]

This is highly related to the registry but as of #772, we're not going to try and build a registry for the time being, so I'm closing this issue