Athens: Add tests for proxy routes

Created on 16 May 2018 · 13Comments · Source: gomods/athens

At the moment there are not tests for cmd/proxy/actions package.

good first issue proxy testing

Source

marpio

👍2

Most helpful comment

@michalpristas Thanks. I'm targeting submitting a PR by the end of this week.

xiaoyunyang on 26 Feb 2019

❤2 🚀1 🎉1 👍1

All 13 comments

I'm going to take this tomorrow 😄

arschles on 9 Aug 2018

@fedepaol I remember you mentioning that you have a PR that added some tests for proxy routes. was it #456?

arschles on 11 Aug 2018

Yes it was that one

Il sab 11 ago 2018, 23:58 Aaron Schlesinger notifications@github.com ha
scritto:

@fedepaol https://github.com/fedepaol I remember you mentioning that
you have a PR that added some tests for proxy routes. was it #456
https://github.com/gomods/athens/pull/456?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/gomods/athens/issues/138#issuecomment-412303928, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAMPcMu8uV7jcJXGocfMBwgJmum09ZWyks5uP1NqgaJpZM4UCDM5
.

fedepaol on 12 Aug 2018

Hi there, guys! I really want to start contributing to Athens so I thought this PR was a good start.

I see the PR suggested by @fedepaol hasn’t been merged yet. Is this still available? Can I start working on a PR for it? 😁

nclandrei on 2 Oct 2018

If @arschles is not working on this anymore you can take it! I think the "tomorrow" mentioned in https://github.com/gomods/athens/issues/138#issuecomment-411591005 has passed long time ago :-)
The relevant pr is https://github.com/gomods/athens/pull/445

Btw the one I suggested (#456) is merged

fedepaol on 2 Oct 2018

Awesome, thanks! :) Awaiting reply then!

nclandrei on 2 Oct 2018

Sorry for not being helpful !

fedepaol on 2 Oct 2018

👍1

No problem at all, @fedepaol! 🙂

nclandrei on 2 Oct 2018

@nclandrei that PR is very out of date so feel free to start another, just comment here if you do and we can close the old one.

robjloranger on 8 Oct 2018

I'd like to take this on if no one else is working on this right now.

xiaoyunyang on 1 Feb 2019

Hey @xiaoyunyang feel free to start, in case of any questions just ping us on Athens slack channel on Gophers slack

michalpristas on 1 Feb 2019

@michalpristas Thanks. I'm targeting submitting a PR by the end of this week.

xiaoyunyang on 26 Feb 2019

❤2 🚀1 🎉1 👍1

@xiaoyunyang I'm going to close this issue now. If you'd still like to write more tests, please feel free to comment here or submit a PR. If you comment here, I'll still get the notification and we can continue the discussion. Cheers! 😄

arschles on 21 Feb 2020

Was this page helpful?

0 / 5 - 0 ratings