Asyncdisplaykit: Huge gifs inside repo

Created on 14 Feb 2017 · 8Comments · Source: facebookarchive/AsyncDisplayKit

Everyone likes GIF and i don't wanna be a party pooper, but the Screenshots folder inside example folder is 64,6 MB. I tried to compress them with ImageOptim and we get 45,1 MB afterwards. but is it really that important to have them inside the repo?

2968

cc @hannahmbanana

Source

MarvinNazari

👍1

Most helpful comment

Agree with @MarvinNazari

@hannahmbanana Can we move them out of the repo to some other image hosting place or into our documentation repo and link to it from there?

maicki on 14 Feb 2017

👍3

All 8 comments

Agree with @MarvinNazari

@hannahmbanana Can we move them out of the repo to some other image hosting place or into our documentation repo and link to it from there?

maicki on 14 Feb 2017

👍3

Good call. :)

hannahmbanana on 14 Feb 2017

@MarvinNazari thanks for filing this. I noticed it when they went in, but since they were already committed, figured it wasn't worth dealing with.

Does anyone know how to actually scrub the files from history? I don't think deleting them from the repo will be enough to remove them from the clone, as Git has to be able to regenerate them if an older commit is checked out.

appleguy on 21 Feb 2017

@appleguy maybe this can help? I haven't try it personally.

MarvinNazari on 21 Feb 2017

@hannahmbanana Would you be able to tackle that this week:

Move the gifs to a different place
Link to new place where necessary
Remove from history

Thanks!

maicki on 21 Feb 2017

I'm nervous about wiping the repo's history

hannahmbanana on 22 Feb 2017

The best way to wipe the history appears to be:

Remove the files in the normal way. They will still be downloaded in a git clone, however.
Let all PRs cycle so that new / active work branches have a commit where the files are removed. Thanks to great efforts by the core team, this is practical because the PR list is kept pretty small these days!
Finally, once the coast is clear, do https://rtyley.github.io/bfg-repo-cleaner/

This appears to be much safer than using the git filter-branch command, which results in different commit hashes for everything. I'm not actually sure how the BFG technique works under the hood, but I THINK it claims to not change the commit hashes.

If there is no way to do this other than changing all the hashes, I'm afraid we should just leave it in history and eventually suggest people clone only a fixed amount of history when they do checkouts.

appleguy on 22 Feb 2017

This issue was moved to TextureGroup/Texture#190