Asyncdisplaykit: [ASViewController] Modal presented ASViewController don't rotate on iOS 8.3

[stephenkopylov]

Hi all!
Minimum supported ios version in my project is 8.3 and I use a lot of AsyncDisplayKit features in it.
But some time ago I faced this strange problem: modal presented ASViewController don't rotate after changing interface orientation. In version > 9.0 it works perfectly, but not in 8.3.

What I tried (and it doesn't help):

- (BOOL)shouldAutorotateToInterfaceOrientation:(UIInterfaceOrientation)interfaceOrientation
{
    return YES;
}

- (UIInterfaceOrientationMask)supportedInterfaceOrientations
{
    return UIInterfaceOrientationMaskAll;
}

Screenshots:

Sample project:
ModalASViewController.zip

[hannahmbanana]

@stephenkopylov: Thanks for the sample project & clear diagram. We will check this out and get back to you soon!

[appleguy]

Levi has the best knowledge of rotation at the moment, but he is away for another week or so.

On Jun 24, 2016, at 11:40 AM, Hannah Troisi [email protected] wrote:

@stephenkopylov https://github.com/stephenkopylov: Thanks for the sample project & clear diagram. We will check this out and get back to you soon!

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/facebook/AsyncDisplayKit/issues/1810#issuecomment-228426934, or mute the thread https://github.com/notifications/unsubscribe/AAigA5pgPZinccjSvKJCdkAUyB-15PP6ks5qPCSegaJpZM4I-ABE.

[maicki]

I looked into that briefly and that is what we get when we call self.view.bounds in viewWillLayoutSubviews: and now we also know why this is happening.

iOS 8
(ASSizeRange) $3 = (min = (width = 375, height = 667), max = (width = 375, height = 667))

iOS 9+
(ASSizeRange) $0 = (min = (width = 667, height = 375), max = (width = 667, height = 375))

We are measuring the root node of the ASViewController in viewWillLayoutSubviews:

[hannahmbanana]

@stephenkopylov: @maicki posted a PR for your issue! Could you try it out and let him know if it works?

[stephenkopylov]

@hannahmbanana
Big thanks to @maicki! Now it works absolutely perfect!
And it would be nice to push this fix to cocoapods... how long it can takes? =)

[hannahmbanana]

@stephenkopylov: Thanks for reporting back! We plan on doing the 1.9.81 release soon. This should hopefully make it into that release.