Similar to future::timeout and Stream::timeout we should add a Future::timeout method.
We already have Future::delay, and timeout would be a great counterpart. This is similar to stdlib's max which is both an inherent method and a free function. Thanks!
yoshuawuyts
All 6 comments
I like to take this if no one is working on it.
miker1423
on 20 Nov 2019
@miker1423 Go for it :)
ghost
on 20 Nov 2019
Sorry for the absence.
As I understood, I should add a new extension method to the Future trait?
miker1423
on 22 Nov 2019
Here is the implementation https://github.com/miker1423/async-std/commit/c1f7be5d42f9fbeb63250e2b4f75986d2ae94fec, I know the docs are incomplete, I just wrote to take away the warning. Is this what was expected?
miker1423
on 23 Nov 2019
@miker1423 yeah that's in the right direction. I don't believe the pub modifiers are needed; pub(crate) should suffice. If you could submit the PR it'd make it easier to review. Thanks heaps for your work!
yoshuawuyts
on 25 Nov 2019
This should be closed with the merged PR #600, thanks!
miker1423
on 26 Dec 2019
Related issues
yoshuawuyts
路
8Comments
humb1t
路
5Comments
imtsuki
路
5Comments
95th
路
7Comments
yoshuawuyts
路
6Comments
Most helpful comment
Sorry for the absence.
As I understood, I should add a new extension method to the Future trait?