actions-rs by @svartalf has been looking fantastic, and I think we should consider using it instead of Travis.
For example today actions-rs/clippy was released, which places clippy checks inline in the PR review:
I think some really good work is being done as part of actions-rs, and by using it we'll probably enjoy faster build times thanks to GitHub actions providing more cycles, and a chance to help Rust tooling development by being able to provide feedback / patches back to a very promising project.
The only open question I have is how this would integrate with Bors, if at all.
yoshuawuyts
All 9 comments
The only open question I have is how this would integrate with Bors, if at all.
Related: https://github.com/bors-ng/bors-ng/issues/730 (Doesn't seem to be officially supported)
taiki-e
on 27 Sep 2019
Example of the clippy checks in action: https://github.com/actions-rs/example/pull/2/files.
yoshuawuyts
on 27 Sep 2019
Isn't it possible to use it with such a change?
https://github.com/samueldple/date_time/pull/45/files#diff-2f8c9db9253b64f9a332c09f492cd54e
k-nasa
on 27 Sep 2019
@k-nasa oh yeah, probably! -- is this something you'd like to try spinning up for our repo?
yoshuawuyts
on 27 Sep 2019
I'll try it! Can you assigne me?
k-nasa
on 27 Sep 2019
Example of the clippy checks in action: https://github.com/actions-rs/example/pull/2/files.
Here is an example of a configuration I'm using that might be useful.
The tarpaulin step takes the longest but there is a PR at actions-rs/tarpaulin that downloads the binary instead of building it and uses the tools cache (same approach should work for the cargo deadlinks install).
ghost
on 27 Sep 2019
It is a closed issue, but I would like to add a late comment: as soon as Github will add proper caching for Actions (AFAIK, mid-November), we try to add caching for installed binaries too; so the first one cargo install will be slow as usual, but the next installations of the same version will use the pre-compiled binary from cache. That would reduce time for all builds, which are installing something.
svartalf
on 30 Sep 2019
@yoshuawuyts
FWIW, I have confirmed that GitHub Actions can integrate correctly with Bors.
https://github.com/taiki-e/pin-project/pull/117/files#diff-3515bd2b4297af2de6456cf6df7c9f4cR1-R10
taiki-e
on 6 Oct 2019
@taiki-e oh that's awesome; thanks so much for sharing that!
yoshuawuyts
on 6 Oct 2019
Related issues
Lonami
路
5Comments
ghost
路
4Comments
matthewrobertbell
路
7Comments
zkat
路
6Comments
Darksonn
路
7Comments
Most helpful comment
It is a closed issue, but I would like to add a late comment: as soon as Github will add proper caching for Actions (AFAIK, mid-November), we try to add caching for installed binaries too; so the first one
cargo installwill be slow as usual, but the next installations of the same version will use the pre-compiled binary from cache. That would reduce time for all builds, which are installing something.