Astroquery: MNT: change single letter internal variables

[bsipocz]

E.g.

• c --> coordinate
• r --> result

or something similar, that make sense in the actual context and not extreme abbreviation. This can be done one module at a time and is very much suitable for folks new to the package, to open source, or to python.

[mfonism]

@bsipocz I'd love to take this up.

I'll make one commit per module, and when the PR gets accepted I can squash them all into one.

[bsipocz]

Sounds like a good plan @mfonism!

Also, given that there are a lot of modules, I would suggest to make a checklist here in the issue to track which ones you have checked and fixed, so you can open a PR before fixing all of them (it also makes it possible for someone else also working on this for a subset of the modules.)

The only tricky bit is making sure that all tests are passing, both local and remote after the changes. (note that there are a bunch of remote ones that are failing, so it's more about making sure there are no new ones failing).
For that you can run python setup.py tests -R -P modulename for the modules you work on. (-R stands for remote, if you work on this while not having internet connection, feel free to omit it, we will just be more careful during review).

[mfonism]

Checklist

• [x] alfalfa (#1859)
• [x] alma (#1859)
• [x] astrometry_net (#1859)
• [x] atomic (#1859 -- clear)
• [x] besancon (#1859)
• [x] cadc (#1859)
• [x] casda (#1859)
• [x] cds (#1859 -- clear)
• [x] cosmosim (#1859)
• [x] dace (#1859 -- clear)
• [x] esa (#1859)
• [x] esasky (#1859 -- clear)
• [x] eso (#1859 -- clear)
• [x] exoplanet_orbit_database (#1859 -- clear)
• [ ] fermi (@nandita11)
• [ ] gaia (@nandita11)
• [ ] gama (@nandita11)
• [ ] gemini (@nandita11)
• [ ] heasarc (@nandita11)
• [ ] hitran (@daisycodes)
• [ ] ibe (@daisycodes)
• [ ] image_cutouts (@daisycodes)
• [ ] imcce (@daisycodes)
• [ ] irsa (@daisycodes)
• [ ] irsa_dust
• [ ] jplhorizons (#1896 -- clear)
• [ ] jplsbdb (#1896 -- clear)
• [ ] jplspec (#1896 -- clear)
• [ ] lamda (#1896 -- clear)
• [ ] lcogt (#1896 -- clear)
• [ ] magpis (#1896)
• [ ] mast (#1896 -- clear)
• [ ] mpc (#1896 -- clear)
• [ ] nasa_ads
• [ ] nasa_exoplanet_archive
• [ ] ned
• [ ] nist
• [ ] noirlab
• [ ] nrao
• [ ] nvas
• [ ] oac
• [ ] ogle
• [ ] open_exoplanet_catalogue
• [x] sdss (#1890)
• [x] sha (#1890)
• [x] simbad (#1890)
• [x] skyview (#1890 -- clear)
• [x] solarsystem (#1890 -- clear)
• [x] splatalogue (#1890)
• [x] svo_fps (#1890 -- clear)
• [ ] template_module
• [ ] tests
• [ ] ukidss
• [ ] utils
• [ ] vamdc (@sebaucillon)
• [ ] vizier (@sebaucillon)
• [ ] vo_conesearch (@sebaucillon)
• [x] vsa (#1880 -- clear)
• [x] wfau (#1880)
• [x] xmatch (#1880)
• [ ] top level files (in astroquery)

[mfonism]

__IMPORTANT__

If you're working on a fix for the aforementioned issue (or plan to work on one) please indicate which module you plan to work on in a comment below. And also, when you're done with your fix, please indicate that it has been fixed, and link to the resulting PR in your comment.

I will update the above checklist accordingly.

This will go a long way to prevent duplication of efforts.

Thank you.

[nandita11]

@mfonism I can help with the following packages, if that's okay!

• [ ] fermi
• [ ] gaia
• [ ] gama
• [ ] gemini
• [ ] heasarc

[mfonism]

Sure @nandita11.

~I'll update~ I've updated the checklist with your name against the five packages.

[daisycodes]

@mfonism I would like to help with the following hitran, ibe, image_cutouts, imcce, irsa.

@HarrietAkot I think this might be a good place to help out since you can't find package-novice tickets to work on.

[HarrietAkot]

Thanks. I will look into it.

On Wed, Oct 21, 2020, 8:51 AM Ngowo Merilyn [e-mail]
wrote:

@mfonism https://github.com/mfonism I would like to help with the
following hitran, ibe, image_cutouts, imcce, irsa.

@HarrietAkot https://github.com/HarrietAkot I think this might be a
good place to help out since you can't find package-novice tickets to work
on.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/astropy/astroquery/issues/1572#issuecomment-713320816,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKUCLLCT4FY2IADJKCDLGADSLZZFLANCNFSM4I7G76VA
.

[mfonism]

That would be awesome, @daisycodes. I've updated the checklist with your name against the packages you mentioned.

[sebaucillon]

@mfonism Hi. I'd like to give xmatch a try. I will get back to you when done to take on more.

[mfonism]

@mfonism Hi. I'd like to give xmatch a try. I will get back to you when done to take on more.

Go ahead, @sebaucillon. I've updated the checklist with your name against xmatch. Could you consider taking on the v* and w* modules (vamdc to wfau) when you're done with this one?

[sebaucillon]

@mfonism Hi. I'd like to give xmatch a try. I will get back to you when done to take on more.

Go ahead, @sebaucillon. I've updated the checklist with your name against xmatch. Could you consider taking on the v* and w* modules (vamdc to wfau) when you're done with this one?

Yes I would. I unfortunately haven't figured out how to test astroquery before submitting my pull request to master but I'll get on with wfau and vsa after that.
Edit: I didn't see vamdc, of course I can take that too.

[sebaucillon]

Hi @mfonism
I have looked into xmatch, wfau, vsa and vamdc.
vamdc is clear of this issue.
The others are still in my fork. I have not made a pull request because I do not have a way to test them due to issues with my working environment. You are all welcome to test my changes for me, I'd appreciate it greatly.
Ciao.

[tinumide]

Hi @mfonism, I would like to take on the s series, sdss, sha, simbad, skyview, solarsystem, splatalogue and svo_fps.

[mfonism]

Hi @mfonism, I would like to take on the s series, sdss, sha, simbad, skyview, solarsystem, splatalogue and svo_fps.

Thank you @tinumide. You can go for it :rocket: