Aspnetcore: 16.8-Preview4 - Validate Razor tooling in Visual Studio Codespaces, Local & LiveShare

[NTaylorMullen]

Instructions

It's up to you to validate all features, if applicable, done in the 16.8-Preview4 (not just your own). Given that this is tooling validation, features and bug fixes should be relatively easy to validate given they don't require complex setups to ensure something works.

As part of this process don't be afraid to experiment outside the context of the issues within the milestone.

Filing issues

All issues found should be filed under the Razor.Tooling milestone and assigned to the Razor Tooling vNext project. Lastly give those issues the appropriate labels and mention them under this issue before closing.

Completing validation

Once you're done with your validation, link to any issues found and unassign yourself from this issue. If you are the last to unassign yourself close the issue and move it to the "Done" column in the Razor Tooling vNext project.

Validation Build

Visual Studio Client Release: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=4112052&view=ms.vss-build-web.run-extensions-tab

1. Install the "Preview" channel version in the "Extensions" tab

Ensure the .NET Core workload is checked:

1. Check the "Connect to Visual Studio Codespaces (private preview only)" preview feature checkbox
   

Visual Studio Server Release: Use the

[NTaylorMullen]

Finished validation. Found:

• https://github.com/dotnet/aspnetcore/issues/26512
• https://github.com/dotnet/aspnetcore/issues/26515
• https://github.com/dotnet/aspnetcore/issues/26520
• https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1224189
• https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1224193

[TanayParikh]

Found

• https://github.com/dotnet/aspnetcore/issues/24895 still repros in Codespaces
  
• https://github.com/dotnet/aspnetcore/issues/23908 still repros in Codespaces
• https://github.com/dotnet/aspnetcore/issues/23519 flash when ALT+UP is used:
  

[gundermanc]

23519 is expected due to the async nature of language server protocol and a desire to not block typing on updates.

I guess in this case we could move the tag position restoration behavior from being async, and part of the LSP request code path, to being done synchronously on the UI thread at GetTags() when an edit doesn't change the text diff, though that's a pretty expensive optimization.

I've added more details to the original issue thread. I propose that we wait for customer feedback before investing in this, as it's a pretty rare corner, and transient.

[NTaylorMullen]

I've added more details to the original issue thread. I propose that we wait for customer feedback before investing in this, as it's a pretty rare corner, and transient.

Agree

[ryanbrandenburg]

• https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1224720
• https://github.com/dotnet/aspnetcore/issues/24351 doesn't happen anymore, but F12 also doesn't navigate to Counter.razor
• https://github.com/dotnet/aspnetcore/issues/26556

[ajaybhargavb]

Done

[NTaylorMullen]

@dibarbet @allisonchou @davidwengier Are you almost done with your part of the verification?

[dibarbet]

@NTaylorMullen doing this afternoon

[allisonchou]

@NTaylorMullen same here - working on it!

[davidwengier]

@NTaylorMullen 3 for 3! I completely forgot about this after doing the VS Code/Mac validation

[allisonchou]

Ran into some already reported issues (https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1224193, #26556), but otherwise everything lgtm!

[dibarbet]

Finished validation for local experience. Saw #23519 but nothing else obvious, other than 1 instance where no lightbulbs were showing up in .razor files until I opened a .cs file. However it only repro'd once and haven't seen it since.

[davidwengier]

Nothing interesting to report. As mentioned elsewhere, I can't do Codespaces :)

[NTaylorMullen]

Thank you everyone for your validation!