Aspnetcore: Pin a couple of packages in 3.0 and 3.1 branches

Created on 22 Jan 2020  路  13Comments  路  Source: dotnet/aspnetcore

After the (long) discussion in #18364 about CoreFx package versions where we only need ref/ assemblies, should also pin the following to their .0 versions in 'release/3.0' and 'release/3.1' branches:

  • Microsoft.Win32.Registry
  • System.Security.Principal.Windows

(We do not seem to need ref/ assemblies from other packages shown in https://github.com/dotnet/runtime/search?q=isnetcoreappref&unscoped_q=isnetcoreappref @ericstj please confirm those properties are the same for 3.0, 3.1 and 5.0 -- GitHub search doesn't help much.)

Extensions

AspNetCore

EFCore, Aspnetcore-Tooling, Blazor, and EF6 don't depend on any of these packages, so nothing is needed there

Done area-infrastructure

All 13 comments

Hmm, can't add this to https://github.com/orgs/aspnet/projects/2 My preference is to:

  • Move that project to the dotnet organization
  • Move the aspnet/AspNetCore-Internal repo to the dotnet organization
  • Update RasS to understand the changed landscape

@Pilchie and @anurse do you know a way to move a project between organizations? If we're agreed, could you do that and the AspNetCore-Internal repo move?

/fyi @ericstj @nguerrera @mmitche

confirm those properties are the same for 3.0, 3.1 and 5.0

Yes we've represented this the same way since 2.0.

@dougbu I don't see a way to move projects between orgs. That's probably because projects can generally only contain issues from repos in the same org, so it gets a little complicated. We could open a new project and work on migrating issues.

As for moving AspNetCore-Internal, I'm fine with that but don't have the necessary permissions in the dotnet org to do so.

As for moving AspNetCore-Internal, I'm fine with that but don't have the necessary permissions in the dotnet org to do so.

I don't either, but @jaredpar could probably do it for us.

Yes I can do it. Can someone positively state they want me to move AspNetCore-Internal to the dotnet org? The language so far is "i'm fine with it". Want to verify before I do the move.

Please go ahead and move AspNetCore-Internal to the dotnet org whenever it's convenient to you, and let me know when you are done.

Assuming it should be named aspnetcore-internal (casing change) to match the other moves?

Yes, sounds good to me.

The transfer has happened. There is one new team though we hadn't ported yet: aspdoi. Do you need that ported? Seems that aspnet-push had enough overlap that this shouldn't be a problem.

Thanks!

For aspdoi I had created it, but apparently not populated it :) https://github.com/orgs/dotnet/teams/aspdoi

It's there for mentioning, not for permissions, so we can do that on our own.

As 3.1.3 has been released, should this be moved to a later milestone?

The issue was resolved in 3.1.3, so should be fine to keep that as its milestone - I guess I just forgot to close it 馃う鈥嶁檪

Was this page helpful?
0 / 5 - 0 ratings