Aspnetcore: [SignalR] Allow controlling maximum buffer size on client

[anurse]

We currently allow control over the "maximum buffer size" on the server: https://docs.microsoft.com/en-us/aspnet/core/signalr/configuration?view=aspnetcore-3.1&tabs=dotnet#advanced-http-configuration-options

(We derive the PauseWriterThreshold and ResumeWriterThreshold values from that).

However, we don't let the .NET client configure this. We should consider doing so to allow the client better control over backpressure.

[BrennanConroy]

Removing milestone to bring back to triage.

We've had another customer report about this.

[davidfowl]

There’s 2 work items. Set a default. Make it configurable

[BrennanConroy]

Right, and if we backport, we can only backport the default value

[davidfowl]

I may take stab at this. We should make sure we have a way to very the memory behavior on our performance lab.

[BrennanConroy]

Right, and if we backport, we can only backport the default value

And also should have an AppContext switch to disable this just in case.

[davidfowl]

I'll do this one. @BrennanConroy I'm assuming it's much easier to test this with the new performance infrastructure right?

[BrennanConroy]

😶
Not sure about easier currently.

[davidfowl]

@BrennanConroy it should also be possible to update the client binaries trivially right 😄

[BrennanConroy]

Yeah, adding something like --load.options.outputFiles <filename> to the command line should do that.