Aspnetcore: Async Model Validation

[bradlis7]

Is your feature request related to a problem? Please describe.

Model validation is synchronous, but if there's a database call or other awaitable call, it would be nice to have an async option.

See https://github.com/aspnet/Mvc/issues/786.

Describe the solution you'd like

Add virtual methods for ValidationAttribute:

Task<bool> IsValidAsync(object value);
Task<ValidationResult> IsValidAsync(object value, ValidationContext validationContext);

Describe alternatives you've considered

Currently working around by using synchronous DB calls.

[DerAlbertCom]

I second this featue Request, but not for the ValidationAttribute (because there is no direct DI for the Attribute and accessing a DbContext needs scoped services).

I have to lookup in the database, and would like to not look the thread ;)

For my perspective with the IAsyncEnumerable of C# 8 i should be possible to create an IAsyncModelValidator.

  public interface IAsyncModelValidator
  {
    IAsyncEnumerable<ModelValidationResult> ValidateAsync(ModelValidationContext context);
  }

[flindby]

Currently we use ValidationAttribute for validating commands (if the id of the command already exist in database for instance). Since the IsValid metods are synchronous we are seeing thread pool starvation under high load, since the call chain to db is blocked. So this feature would be highly appreciated.

Our temporary "work around" is to explicitly set the ThreadPool min size, which seem to work. Such as:

var threadCount = 1000;
ThreadPool.GetMaxThreads(out _, out var completionThreads);
ThreadPool.SetMinThreads(threadCount, completionThreads);

Someone "solved" it in another fashion?

[aammfe]

1- just synchronous validation
2- if errors in one in 1 then skip 3
3- asynchronous validations

[mkArtakMSFT]

Thanks for contacting us, @bradlis7.
This is not something we plan to do in the near future.