Aspnetcore: Remove dependencies from the default set adding by ConfigureWebHost

Created on 12 Nov 2018  路  8Comments  路  Source: dotnet/aspnetcore

Today we add a set of dependencies that mirror the WebHostBuilder https://github.com/aspnet/Hosting/blob/d7b9fd480765bdc01f06441f308fb288e6001049/src/Microsoft.AspNetCore.Hosting/WebHostBuilder.cs#L270-L285. Things we may want to remove:

  • ObjectPoolProvider
  • DiagnosticListener/DiagnosticSource

@Tratcher @rynowak

area-hosting breaking-change

Most helpful comment

more pay for play

What does this phrase in the announcement mean?

All 8 comments

Are you tracking the removal of server.Urls and other obsolete config settings somewhere?

I removed the server.urls in the PR.

more pay for play

What does this phrase in the announcement mean?

@sandersaares Components that require the ObjectPoolProvider add it instead of it being added for everyone (it was only used in 3 places). Where as something like logging is user by every component.

I'm not a big fan of dependencies being added by default, and I suspect there are going to be more cases where dependencies are added like so, is there going to be a wider review to see if we can make improvements elsewhere as part of this breaking change?

I'm not a big fan of dependencies being added by default, and I suspect there are going to be more cases where dependencies are added like so, is there going to be a wider review to see if we can make improvements elsewhere as part of this breaking change?

Yes the dependencies listed are the ones that are problematic/unnecessary. The other dependencies are pretty much required to function.

I'm not sure we can easily remove the diagnostic source. I need to think about that one more.

Closing this as we're not going to remove (at least in the short term, the DiagnosticSource)

Was this page helpful?
0 / 5 - 0 ratings