Aspnetcore.docs: Add HttpClient disposal pattern recommendation, changes & ramifications
HttpClient implements IDisposable (always has) yet there is no mention or discussion of what's the recommended usage pattern with respect to instances returned by an IHttpClientFactory.
Document Details
⚠Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.
- ID: 881cef77-11ef-ac11-06d0-0996a1ccfa1b
- Version Independent ID: 3d356334-e672-7e8b-1fef-7944ebee99eb
- Content: Initiate HTTP requests
- Content Source: aspnetcore/fundamentals/http-requests.md
- Product: aspnet-core
- GitHub Login: @stevejgordon
- Microsoft Alias: scaddie
atifaziz
All 2 comments
@stevejgordon or @glennc Thoughts?
scottaddie
on 26 Jun 2018
Reading from https://blogs.msdn.microsoft.com/webdev/2018/02/28/asp-net-core-2-1-preview1-introducing-httpclient-factory/
This says..."Disposing of the client is not mandatory, but doing so will cancel any ongoing requests and ensure the given instance of HttpClient cannot be used after Dispose is called. The factory takes care of tracking and disposing of the important resources that instances of HttpClient use, which means that HttpClient instances can be generally be treated as .NET objects that don’t require disposing. One effect of this is that some common patterns that people use today to handle HttpClient instances, such as keeping a single HttpClient instance alive for a long time, are no longer required. Documentation about what exactly the factory does and what patterns it resolves will be available, but hasn’t been completed yet."
topanoe
on 5 Jul 2018
Related issues
aaron-bozit
·
3Comments
Rick-Anderson
·
3Comments
YeyoCoder
·
3Comments
Rick-Anderson
·
3Comments
Rick-Anderson
·
3Comments
Most helpful comment
Reading from https://blogs.msdn.microsoft.com/webdev/2018/02/28/asp-net-core-2-1-preview1-introducing-httpclient-factory/
This says..."Disposing of the client is not mandatory, but doing so will cancel any ongoing requests and ensure the given instance of HttpClient cannot be used after Dispose is called. The factory takes care of tracking and disposing of the important resources that instances of HttpClient use, which means that HttpClient instances can be generally be treated as .NET objects that don’t require disposing. One effect of this is that some common patterns that people use today to handle HttpClient instances, such as keeping a single HttpClient instance alive for a long time, are no longer required. Documentation about what exactly the factory does and what patterns it resolves will be available, but hasn’t been completed yet."