Aspnetcore.docs: Update Configure Identity page for 2.0

Created on 12 Sep 2017  路  5Comments  路  Source: dotnet/AspNetCore.Docs

Unless it's already taken, I'd be willing to submit a PR for this page to be updated for 2.0 - https://docs.microsoft.com/en-us/aspnet/core/security/authentication/identity-configuration

P1

Most helpful comment

Sure feel free to document all of the options... Its probably also worth pointing out that you can configure them directly inside of AddIdentity(options => ...) as well

All 5 comments

@scottsauber It's all yours. Thank you for volunteering. Let me know if you need help with anything.

Awesome! A few questions before I get started:

  1. Any opposition to adding some more context with those options like where they go in Startup. Reading some of the comments, there were some that weren't 100% sure where these go.

So instead of:

// Password settings
options.Password.RequireDigit = true;
options.Password.RequiredLength = 8;
options.Password.RequireNonAlphanumeric = false;
options.Password.RequireUppercase = true;
options.Password.RequireLowercase = false;

Replace with:

services.Configure<IdentityOptions>(options =>
{
      // Password settings
      options.Password.RequireDigit = true;
      options.Password.RequiredLength = 8;
      options.Password.RequireNonAlphanumeric = false;
      options.Password.RequireUppercase = true;
      options.Password.RequireLowercase = false;
});
  1. Seems like we can get rid of the highlight? Not sure what it's highlighting.

  2. Is it ok to document the UserOptions and SignInOptions here? So like each would be their own sections like the Password options, but would document these:

services.Configure<IdentityOptions>(options =>
{
    options.User.RequireUniqueEmail = true;

    options.SignIn.RequireConfirmedEmail = true;
    options.SignIn.RequireConfirmedPhoneNumber = true;
});

Let me know what you think @scottaddie. Thanks!

@scottsauber

  1. More context is always a good thing, especially if there are Livefyre comments indicating confusion.
  2. Remove highlighting
  3. @HaoK Thoughts on question 3 above? It seems like there's a lot we could do to make the doc more useful.

Sure feel free to document all of the options... Its probably also worth pointing out that you can configure them directly inside of AddIdentity(options => ...) as well

Started on this and will send the PR tomorrow.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

AnthonyMastrean picture AnthonyMastrean  路  3Comments

nenmyx picture nenmyx  路  3Comments

Rick-Anderson picture Rick-Anderson  路  3Comments

neman picture neman  路  3Comments

fabich picture fabich  路  3Comments