Aspnetcore.docs: Is it fine to say "Run the page"?!

[badersur]

I'm seeing this 3 times in https://docs.microsoft.com/en-us/aspnet/core/data/ef-mvc/sort-filter-page and it doesn't seem alright to me! Maybe it should be "Run the app" or "Refresh the page"...

I'm wondering how I was able to include an absolute code URL in my last issue! I can't do it again to include an example here :/

[scottaddie]

@Rick-Anderson Any preferences on the verbiage? I was thinking something like "Browse to the page".

[badersur]

I've found another occurrence in https://docs.microsoft.com/en-us/aspnet/core/data/ef-mvc/complex-data-model:

Run the Students Index page again and notice that times are no longer displayed for the enrollment dates.

[Rick-Anderson]

Refresh the Students Index page ~again~ and notice that times are no longer displayed for the enrollment dates.

[badersur]

I'm not sure about fixing this issue because there're several variations:

In crud there're:

Run the application, select the Students tab, and click the Details link for a student. (looks fine to me but included to show variations!)

Run the application and select the Students tab, then click an Edit hyperlink. (seems fine!)

Run the page by selecting the Students tab and clicking Create New. (change "page" to "application", and use the previous structure (i.e. run ... and select ..., then ..)?)

Run the page by selecting the Students tab and clicking a Delete hyperlink: (same as above)

In sort-filter-page:

Run the page and click the Last Name and Enrollment Date column headings to verify that sorting works. (Refresh the page?)

Run the page, enter a search string, and click Search to verify that filtering is working. (Refresh the page?)

Run the page. (Change to "Refresh the page"?)

Run the app and click the About link. The count of students for each enrollment date is displayed in a table. (looks fine to me!)

In complex-data-model

Run the Students Index page again and notice that times are no longer displayed for the enrollment dates. The same will be true for any view that uses the Student model. (refresh ... again)

Run the Create page, and enter either name longer than 50 characters. When you click Create, client side validation shows an error message. (refresh)

Should I use a mixture of run and refresh? Are suggested edits in () fine?

[scottaddie]

@tdykstra Do you have any preferences on the verbiage used here?

[tdykstra]

In general the suggested edits are OK. Could simplify in some cases by using "Go to the x page"; "Refresh the page" only works if it's a subsequent time and it's safe to assume they left the browser window open.

[badersur]

Any one planning to submit a PR for this? or working on it? I may be able to fix it tonight or tomorrow!

[badersur]

Unfortunately I didn't have time for this!

[scottaddie]

@badersur Nobody is working on this. If you have time to submit a PR, it would be greatly appreciated.

[badersur]

Maybe I'll be able to work on it next week!

[badersur]

I'm trying to update these files to use refresh and go to x page but now I realize that we need to re-run the application after changing C# code (as far as I know since we didn't use dotnet watch! Does VS re-run ASP.NET Core apps on the background?! I didn't notice this..)
Or we can assume developers will re-run the app if refresh didn't work!

[badersur]

It seems I'll just use "run the application" everywhere...

[tdykstra]

Or change text like "run page x" to:

"run the app and navigate to page x"

or shorter

"run the app and go to page x"