Affects fundamentals/configuration.md and others.
Document Options 2.0 changes #3469
@rachelappel There's a question that's come up while I was working these config samps. Not working this topic; just updating the samps to 2.0 on PRs: #4197, #4198, #4199, #4200, #4201, #4205, #4206, #4207 (all to address getting rid of dnxcore50
on #1950) ... and three upcoming PRs on Tue 9/5 (no dnxcore50
, but I may as well ... I'm on a roll! :smile:). One sample, IOptionsSnapshot2
is outside of the src folder. Not sure why that was placed there, but it's also unclear if you want to move all of the samps out of src and into the sample folder. I'll (quickly) get the samps updated, then get out of your way here.
[Dots indicate orphaned samps that are slated for obliteration.]
@guardrex @rachelappel I recommend moving all the sample code under "sample" and deleting the "src" folder. The "src" folder was used in VS 2015 project templates. Since it isn't used in the VS 2017 project templates, it's probably best to move away from it.
Very good. There was one other one in my batch for #1950 that had has an (unnecessary) src+test folder layout. IIRC the test projects are well-named, so they can sit in the sample folder next to the project folder. I've made a note here to circle back around to it.
This batch is a little different in that the src folder holds completely separate projects ... not test vs. app ... so yeah ... it makes very little sense here at all, even under VS2015.
I'll take care of the other one, but I'll leave these Configuration projects in the src to be worked on this PR.
There are three here that need upgrade to 2.0, and I'll get them today right after I get back from the 馃挭 gym and a quick 馃毚 bike ride.
Cross-ref: https://github.com/aspnet/Configuration/issues/728
... but it isn't 100% clear if this is the tracking topic for ALL configuration topic updates for 2.0 (e.g., ConfigureAppConfiguraton
).
@guardrex I'll be adding a small section to the existing migration doc to outline ONLY major breaking changes. (see issue https://github.com/aspnet/Docs/issues/4277). This issue should remain open, and the resulting doc should serve as a much more detailed reference.
@rachelappel I'm looking at https://github.com/aspnet/Docs/issues/1382 and wondering if you think I have time to sneak a quick-ish (24-48 hours) PR in there to cover that before you go to work on this issue?
@guardrex Yep. I am working on another issue at the moment and have a second one I can bump up in the queue in the meantime so no problem there.
@scottaddie Ok with you? ... kills two :bird: :bird: ... that issue and wraps up https://github.com/aspnet/Docs/issues/2409. Be nice if [@]Rick-Anderson comes back to fewer issues than he left (if that's possible lol).
@guardrex Sounds good to me!
@rachelappel Update on https://github.com/aspnet/Docs/pull/4307 The work is done ... just waiting on review. I'll jump on feedback asap to get out of your way here.
@Rick-Anderson Since options are part of the config topic and probably will be addressed at the same time, should #3469 be closed and tracking that work be done over here?
Most helpful comment
Very good. There was one other one in my batch for #1950 that had has an (unnecessary) src+test folder layout. IIRC the test projects are well-named, so they can sit in the sample folder next to the project folder. I've made a note here to circle back around to it.
This batch is a little different in that the src folder holds completely separate projects ... not test vs. app ... so yeah ... it makes very little sense here at all, even under VS2015.
I'll take care of the other one, but I'll leave these Configuration projects in the src to be worked on this PR.
There are three here that need upgrade to 2.0, and I'll get them today right after I get back from the 馃挭 gym and a quick 馃毚 bike ride.