Aspnetcore-angular-universal: Milestone for Angular 5

[mcgri]

Hi

First of all, thank you for your effort bringing angular universal to .core ecosystem.
Could you please add a milestone for angular 5 migration? It will be easier to watch the progress of migration to angular 5...
Or at least, please provide a list of issues which should be closed before migration to angular 5 could happen.

Thank you

[MarkPieszak]

Sure! So Angular 5 was setup, but then there were some big production issues I didn't realize we'd face, some of the issues included:

• [x] Fix AngularCompilerPlugin to handle our use case
  
  
  
  • [x] Get it to allow us to compile AoT on the fly correctly
  
  
  • [x] PR has been made in Angular-CLI just need for it to be published
    
    angular/angular-cli#8951
  
  
• [ ] Fix platform-server ServerTransferService to run before any other BEFORE_APP_SERIALIZE events
• [x] Test dev & prod workflows

Lastly the most important one is:

• [ ] Move to Angular-CLI based template

It might be better for us to move towards that regardless, as it'll solve the above issues (since AngularCompilerPlugin for example was built with the CLI in mind, etc).

A lot to think about :)

[MarkPieszak]

Waiting on ngtools/webpack PR to get merged and published here and this should allow us to upgrade back to Angular 5.x
angular/angular-cli#8951

[mcgri]

Good news:) can't wait... Christmas is comming :))

On 20 Dec 2017 22:17, "Mark Pieszak" [e-mail] wrote:

Waiting on ngtools/webpack PR to get merged and published here and this
should allow us to upgrade back to Angular 5.x
angular/angular-cli#8951
https://github.com/angular/angular-cli/pull/8951

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/MarkPieszak/aspnetcore-angular2-universal/issues/516#issuecomment-353198948,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ALwXD06NPGSopJ3nYBVwvp1t3zmrzwo3ks5tCYeXgaJpZM4RAbfl
.

[Adondriel]

Oh man, moving to angular client is going to be fun. Does that mean we will be getting rid of webpack? Cause... I JUST finally got my head wrapped around how the hell that works! lol.

[Adondriel]

@MarkPieszak Will updating to Angular 5 fix the issue of not being able to have DOM elements be used in our code?

[MarkPieszak]

No you'll still not be able to use browser only APIs like document.querySelector / navigator or anything window, but you'll have access to DOCUMENT from common which is a server implementation of the Document, so if you use that, you can do querySelectors for example. But typically if you're trying to query things, there's probably a better more Angular way of doing it, so try to avoid that :)

Yes, the CLI will make life a lot easier!

[Adondriel]

Awesome, I'm trying to get https://github.com/swimlane/ngx-charts to work, and I just found out that their branch for updating to ng5, has the fix I'm gunna need, probably.

[jerkovicl]

Any ETA for those production issues?

[mcgri]

@MarkPieszak they merge mentioned PR 🥇 . Our team needs to push code to production, urgently. how could we make a hot fix for aot bugs?

[odahcam]

I simply disabled AOT to don't lose SSR. It appears that we have to make a choice here, between AOT or SSR. :/

I think we should just track https://github.com/MarkPieszak/aspnetcore-angular2-universal/issues/482 and try to find a solution for that.

[mcgri]

I thought the fix from angular teams (https://github.com/angular/angular-cli/pull/8951) should allow compiling the AOT. Just general off topic l info, I disabled both SSR and AOT, and the system works on Azure with all kestrel goodies, so the pages loading in 800ms due to cache. The SSR and AOT will cut the script rendering times,which will reduce total loading times from 2sec to just 1..which is faster then Amazon (our system have more then 100 components :)) )

[odahcam]

I'm trying to discover if it was really fixed, but I got no responses.

[MarkPieszak]

The 5.0 version is fixed, I'm now merging the PR #538 into Master.
Take a look and let me know!

It's not totally perfect, but Production builds are finally possible.

Hopefully in a few weeks I'll have the transition to the CLI-based template in there, and we'll be in even better shape 👍

Closing for #539