Asdf: Any plans for PHP?

[rstacruz]

¯_(ツ)_/¯

[Stratus3D]

I just started a PHP plugin: https://github.com/Stratus3D/asdf-php. Creating a plugin is simple so I will hopefully have this plugin finished today.

[HashNuke]

@Stratus3D :heart: :+1:

[HashNuke]

@Stratus3d b/w no hurry.

[HashNuke]

Marking this issue as "help wanted". Anyone looking to contribute, please contribute directly to @Stratus3D's repository here - https://github.com/Stratus3D/asdf-php

[crbelaus]

This is so great :heart:

[odarriba]

I've created a plugin (based on @Stratus3D code) that works fine at least in OSX and Ubuntu.
It has been tested installing PHP 7.x.x and 5.6.x, so more testing would be appreciated.

https://github.com/odarriba/asdf-php

[crbelaus]

Works wonderfull on a Symfony 2.8 installation with Sylius. Good job! :+1:

[Stratus3D]

That's awesome! As you have seen, I really dropped the ball with asdf-php. I don't use PHP regularly so I wasn't motivated to finish it.

I'd like to list this plugin in the asdf readme, but the plugin must pass asdf's plugin-test command first. Can you setup a travis CI build for the repository? It's really easy to do. Here is the .travis.yml file from my asdf-lua plugin: https://github.com/Stratus3D/asdf-lua/blob/master/.travis.yml

I'll do some testing of the plugin myself and let you know if I find any issues. I'd also like to remove my asdf-php repository to make it clear that yours is the canonical PHP plugin and to avoid confusing future asdf users. I will delete mine once you setup the Travis build.

Thanks!

[odarriba]

I've successfully added TravisCI to the repository.

Just saying that I encounter a big issue with Travis: the OSX public IP was temporarily banned from Github API due to quota exceed. To solve it, I have added the possibility of using custom GitHub credentials via environment variables (and added them using secret env variables of Travis).

Hope this can make this repository added to official README ! :)

[odarriba]

And I have also added information of that issue and how to solve it in the README of the repo.

[HashNuke]

@odarriba Thank you for the plugin. Can you send a PR to add it to the plugin list on the readme?

[rstacruz]

Nice work everyone! 😍

[crbelaus]

The dependencies for PHP compilation should be added along with the dependencies for the rest of the packages?

[Stratus3D]

@odarriba do you want that secret environment variable checked into the asdf-php repo? That seems like it would contain your login credentials.

[Stratus3D]

@belaustegui I think PHP dependencies should remain separate from asdf dependencies if that's what you mean. Many asdf plugins have additional dependencies.

[Stratus3D]

@odarriba I just deleted my repo, now yours is no longer a fork.

[odarriba]

@Stratus3D As I have read, that secure env variable is the recommended method by Travis to store credentials and so on. It uses a pair of RSA keys to store credentials securely, so only Travis con read them.

If I don't use it, it can produce errors since the build servers can be banned from Github API (as occurred in the OSX build of PHP plugin).

[odarriba]

More info: https://docs.travis-ci.com/user/environment-variables/#Defining-encrypted-variables-in-.travis.yml