Asciidoctor-pdf: Inline images don't work in normal table cells

Created on 3 Aug 2015 · 13Comments · Source: asciidoctor/asciidoctor-pdf

Inline images don't work in non-AsciiDoc table cells. Likely the callbacks for rendering inline images need to be registered specifically on the table cell so that they get invoked.

compliance

Source

mojavelinux

👍3

All 13 comments

Actually, they do work, so long as they fit within the table cell. If the image is too big to fit in the table cell, it will not show. The cell should be expanded in size to fit the image (or the restriction needs to be documented).

mojavelinux on 7 Nov 2015

...so to reproduce the issue, make the image width sufficiently large.

mojavelinux on 7 Nov 2015

Do you have an easy way to adjust the height of the cell/row?

wingfire on 9 Jun 2016

Not at the moment. The height adjusts based on the text content.

mojavelinux on 11 Jun 2016

I gave my answer assuming you were asking whether it's possible to set the height from AsciiDoc. I'm sure there's a way we can tell Prawn to increase the height internally.

mojavelinux on 20 Sep 2016

👍1

Comments suggest this has been fixed + still appears broken.

This works...

image::/your-connection-is-not-private.jpg[]

This fails...

davidfavor on 13 Oct 2016

Hum...

image: (one colon) seems to work + image:: (two colons) seems to fail.

davidfavor on 13 Oct 2016

You are correct. One colon is an inline image, and that works in table cells (with the exception that the image must fit within the size of the cell). Two colons is a block image and that doesn't work yet because Asciidoctor PDF doesn't yet support AsciiDoc table cells. See #6.

mojavelinux on 14 Oct 2016

Even with the fix for #620 (and even #388), it seems like we have an ordering issue in the calculation. The image cell is trying to make a determination about the available space for the image and getting it wrong. I can't even quite determine how it is doing the calculation.

The best workaround is to size the image so it's small enough to fit in the cell.

mojavelinux on 5 Dec 2016

Aha!!! I figured it out. When we set the font properties on the placeholder fragment, we aren't distributing the height correctly. This leads to a negative line gap, which causes the cell to not leave enough space for the image. I'll submit a patch to correct these assignments.

mojavelinux on 17 Dec 2016

🎉1

Is this issue really resolved? I am using Asciidoctor PDF 1.5.0.alpha.13 and I am experiencing exactly the same thing. I have a table with 2 columns, the first one containing an image, the second one its description. When the description is stretched across more lines, the image gets shown when it is small enough, but if its bigger, then there is an empty space even though the row itself is much higher than the text in the second column.