Arviz: Typo in plot_dist

Created on 9 Oct 2020  路  9Comments  路  Source: arviz-devs/arviz

Describe the bug
One of the errors in plot_dist says use xarray.Dateset. Should be dataset
https://github.com/arviz-devs/arviz/blob/master/arviz/plots/distplot.py#L166

Expected behavior
Should read as as xarray.Dataset

Beginner

Most helpful comment

Hi, could I pick this one up?

All 9 comments

Hi, could I pick this one up?

Yes.

I no dubtis en preguntar aqu铆 o a gitter si tens cap dubte!

Hey, has this one been fixed yet ?

Hi @virajone, thanks for your interest in ArviZ!

The issue has not been fixed yet, but work on it has already started. Therefore, as stated in our contributing guide in order to prevent duplicated work, you should find other contributions to work on.

I see you have already commented on a second issue but I still want to say that we can also help in finding issues/features that fit your interests

@OriolAbril , thanks a lot for your response. I would surely like to contribute and I appreciate your help. I am looking for an issue that's beginner friendly and relatively easy given that I'm new to the project. Would be great if you can assign / assist me finding one. :)

In my opinion, the lowest hanging fruits currently are #1188 and #956 (the issue description may be very clear but I can work on that). They affect multiple files but I woule encourage to tackle them 1-2 files per PR. #681 could also be a good candidate.

I also consider #1318 to be low hanging fruit but it requires knowing about benckmarking, something similar to numba's notebook. kde calls many utilities and I think some of them won't need any change in their code to benefit from numba. I can help id the candidates so the task would be to try and experiment with the benchmarcks to see if this vanilla numba can speed up our kde function. We probably can find other similar issues that have some specific requirement and they don't have the begginer label but if you already know this or want to learn it they can still be a good fit.

Sorry for the late reply, I opened #1414 that will close this issue. I'm new to open source so I don't know if I should link the issue to the PR in this way 馃槙

I don't know if I should link the issue to the PR in this way

1414 is great. Provided that like in this case a PR aims to close an open issue, the recommended way to link PR and issue is mentioning the issue from the PR description with one of these keywords, fixes is one of them so you can already see above the

JoanRosell linked a pull request that will _close_ this issue 6 hours ago

Thanks to these keywords, GitHub will close the issue once the PR is merged

Was this page helpful?
0 / 5 - 0 ratings