Arrow: Master commit status

Created on 8 Oct 2019  路  10Comments  路  Source: arrow-kt/arrow

We need to notify Maintainers and the respective Authors of unsuccessful PR pushes to master.

Current state of art:
An approved and green PR doesn't imply a healthy commit to master, neither hard pushes to master.

Proposal:
In order to move towards faster release cycles, we need to anticipate the aforementioned issues. Adding a Github action for an email to the respective parties should do it for now.

Feel free to add comments and suggestions.

enhancement

All 10 comments

Draft pull request in progress: #1694

BTW, GitHub Actions has amazing features like:

  • Greeting users who are first time contributors to a repository
  • Labeling pull requests based on the files changed
    etc.

NOTE: To configure notifications for GitHub Actions:

https://github.com/settings/notifications

Screenshot from 2019-10-10 19-50-56

Hi @i-walker!

I found this note in Travis CI notifications documentation:

The email address is determined based on the email address in the commit, but only if it matches one of the email addresses in our database.

and your email address is:

[email protected]

That can be the reason why you don't receive notifications:

The most common cause for not receiving build notifications, beyond not having a user account on Travis CI, is the use of an email address that鈥檚 not registered and verified on GitHub.

However, I also have an anonymous email for my commits and I receive GitHub Actions notifications in the default notifications email. So having an anonymous email for commits won't be a problem if we migrate to GitHub Actions.

This issue can be closed. We're already receiving emails from [email protected] when a build fails.

Boop!

@arrow-kt/maintainers Please check that you're successfully receiving emails about failures in your PRs and feel free to reopen this if there's any issue 馃憤

I'll close the issue once this is resolved :)

Besides email notification, we'll add issue creation in case of error for the new arrow organization.

Thanks @rachelcarmena ! 馃槃

Was this page helpful?
0 / 5 - 0 ratings

Related issues

raulraja picture raulraja  路  4Comments

JLLeitschuh picture JLLeitschuh  路  4Comments

ovu picture ovu  路  4Comments

jmfayard picture jmfayard  路  4Comments

JorgeCastilloPrz picture JorgeCastilloPrz  路  3Comments