Armeria: Provide a way to invoke Thrift `*.AsyncIface` implementations via `blockingTaskExecutor`.

Created on 31 Oct 2019  路  4Comments  路  Source: line/armeria

We need something similar to GrpcServiceBuilder.useBlockingTaskExecutor() in Thrift, e.g. THttpService.builder().useBlockingTaskExecutor(...).build().

/cc @delegacy

new feature will not fix

Most helpful comment

Sorry for a really long consideration, but... 馃槄

I'm thinking this does not introduce any advantage because normally users must implement AsyncIface in an asynchronous way. I feel like this feature just allows users to make mistakes. (blocking implementation in AsyncIface)

Any thought?

All 4 comments

Will prepare a PR soon.

Sorry for a really long consideration, but... 馃槄

I'm thinking this does not introduce any advantage because normally users must implement AsyncIface in an asynchronous way. I feel like this feature just allows users to make mistakes. (blocking implementation in AsyncIface)

Any thought?

Agree that unlike gRPC thrift doesn't really need it since there are two types of interface classes.

Let me close this issue, then. Please feel free to create a new issue if the situation has changed.

Was this page helpful?
0 / 5 - 0 ratings