Armeria: Typo of an example on line.github.io

Created on 23 Oct 2019  路  3Comments  路  Source: line/armeria

Hi folks,

Thanks for this great lib.

This is an issue about a typo on the web site: https://line.github.io/armeria. I scanned all the repositories here but failed to find the repository for https://line.github.io/armeria. So I leave this issue here. If this is an inappropriate place, please let me know and I will happily move this issue to the right place even taking a PR. Thanks.

At this page, there are some socket options to tune for production. The example is :

// Server-side
ServerBuilder sb = Server.builder();
sb.channelOption(ChannelOption.SO_BACKLOG, ...);
sb.channelOption(ChannelOption.SO_SNDBUF, ...);
sb.channelOption(ChannelOption.SO_RCVBUF, ...);

But the ChannelOption.SO_SNDBUF option is for sb.childChannelOption() instead of sb.channelOption(). Otherwise, there's a warning log will show, like:

xx:xx:xx WARN  io.netty.bootstrap.ServerBootstrap - Unknown channel option 'SO_SNDBUF' for channel '[id: xxxxxxx]'
documentation

Most helpful comment

No worries my friend. It's good to see this fixed so soon.
Hope you have a good day! :grinning:

All 3 comments

Yes, this is the right place. Thanks a lot, @ylgrgyq! Let me send a fix soon.!

I will happily move this issue to the right place even taking a PR.

@ylgrgyq, I'm really sorry that I missed this comment. 馃槩
We really appreciate that you found this and hope to see your PR next time. 馃槄

No worries my friend. It's good to see this fixed so soon.
Hope you have a good day! :grinning:

Was this page helpful?
0 / 5 - 0 ratings