Argo: Add `--selector` and other useful flags to `argo {stop,terminate,resume,etc.}`

Created on 2 Sep 2020  路  8Comments  路  Source: argoproj/argo

Summary

Add --selector and other useful flags to argo {stop,terminate,resume,etc.}

Use Cases

You can list certain workflows with argo list --selector ..., you should be able to stop the same list of workflows



Message from the maintainers:

Impacted by this bug? Give it a 馃憤. We prioritise the issues with the most 馃憤.

enhancement good first issue help wanted

All 8 comments

@simster7 If nobody takes this issue, can I try it as my first contribution?

Feel free to do so!

@simster7 If nobody takes this issue, can I try it as my first contribution?

I would also like to do so. Is there any way we can collaborate on this as I am also new to Golang.

I can also assist, please let me know.

@neel229 @rajneeshbajaj I'll create a PR where we can work together first and let you know. Sorry for late.

@rajneeshbajaj @neel229 I've created the draft to work (#3962). I'm planning to add options (--selector, --field-selector) to these commands:

  • stop
  • terminate
  • resume
  • retry

Please comment if you have any questions.

@simster7 One question, how could I add a unit test for codes of command?

We're refactoring our CLI testing code right now, but for now you can add them under test/e2e/cli_test.go

Hi @simster7 ,
is this for the greb ?

Was this page helpful?
0 / 5 - 0 ratings