Argo: spec.activeDeadlineSeconds is not honored by resource templates

[jessesuen]

Is this a BUG REPORT or FEATURE REQUEST?: BUG REPORT

What happened:

activeDeadlineSeconds at the workflow.spec level, is not honored by resource templates

What you expected to happen:

spec.activeDeadlineSeconds should work for resource templates.

How to reproduce it (as minimally and precisely as possible):

apiVersion: argoproj.io/v1alpha1
kind: Workflow
metadata:
  generateName: k8s-jobs-
spec:
  activeDeadlineSeconds: 10
  entrypoint: pi-tmpl
  templates:
  - name: pi-tmpl
    resource:
      action: create
      successCondition: status.succeeded > 0
      manifest: |
        apiVersion: batch/v1
        kind: Job
        metadata:
          generateName: sleep-
        spec:
          template:
            metadata:
              name: sleep
            spec:
              containers:
              - name: sleep
                image: alpine
                command: [sleep, "999999"]
              restartPolicy: Never
          backoffLimit: 4

Environment:

• Argo version: v2.3.0-rc2, v2.2.1

[jessesuen]

Note that activeDeadlineSeconds is honored at the template level.

[terrytangyuan]

Thanks for filing this @jessesuen. cc: @ywskycn @zhujl1991

[zhujl1991]

@jessesuen can you assign this to me? I'll try to fix this.

[terrytangyuan]

@zhujl1991 Correct me if I am wrong but I think you'll need to be a collaborator of this repo in order to be assigned issues. It should be fine as long as other people who come across this issue know that you are working on this.

[zhujl1991]

@jessesuen your yaml in your "reproduce" section actually works well -- you should move activeDeadlineSeconds: 10 to spec so that it can reproduce the issue.

[Ark-kun]

Is it possible that the same issue breaks termination when retry is used? https://github.com/argoproj/argo/issues/1620

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.