Argo-cd: Rollback should disable autosync

[estahn]

Is your feature request related to a problem? Please describe.

Doing a rollback via the UI will return the following error message:

Unable to rollback application: rollback cannot be initiated when auto-sync is enabled

This is counter-intuitive for an end-user as he will now go into app-settings and disable auto-sync. A one-click rollback now becomes a more complicated endeavour.

Describe the solution you'd like

Clicking rollback via the UI should include all the actions required to execute the rollback, e.g. disable auto-sync.

Have you thought about contributing yourself?

Yes.

[alexec]

Good idea. This could be a UI only change and therefore a good one for community contribution. I think the change would be around here:

https://github.com/argoproj/argo-cd/blob/f6545cd56ae0cbdbc40b4cf57db190d06217ccef/ui/src/app/applications/components/application-deployment-history/application-deployment-history.tsx#L50

[estahn]

@alexec I think this is also required in the CLI. At the moment you will have to disable sync policy via argocd app set <app> --sync-policy none before doing a rollback.

[alexec]

CLI changes could probably be done here:

https://github.com/argoproj/argo-cd/blob/f6545cd56ae0cbdbc40b4cf57db190d06217ccef/cmd/argocd/commands/app.go#L1298

[adamjohnson01]

@estahn, are you planning on implementing this?

[adamjohnson01]

@alexec , as far as I can tell rollbacks are only ever initiated by a user. Would it not be better to make changes here instead of both the ui and the cli?

https://github.com/argoproj/argo-cd/blob/73590e1a3982501865577c2a2c9ec8794391b813/server/application/application.go#L989

[estahn]

@adamjohnson01 I would like to, I'm just short on time at the moment. If anyone else wants to go ahead don't wait for me :)

[alexec]

@adamjohnson01 @jessesuen @alexmt my feeling is that when you click rollback, you should be told that auto-sync is enabled and needs to be disabled to rollback. You should be shown a button that disables it and then continues the sync.

I think this should be a UI change, rather than a backend change. Thoughts?

[adamjohnson01]

@alexec, for the cli we could add a disable-autosync flag to the rollback command.

The UI has a pop up asking if you are sure you want to rollback. How about adding a warning that autosync will be disabled if you rollback as you already have to click rollback then ok? In our experience we have only ever used rollback when there is an issue and we want to revert as quickly as possible.

[alexec]

I still think this should be UI only - in the pop-up you could have a button to disable it.

[adamjohnson01]

Sure, I will move it to the UI. I just meant I was not sure that the extra button was required.

[alexmt]

I don't have very strong opinion about it but I would still keep most of the logic on server side.

Not 100% sure we should let user ability to keep auto-sync, but to archive it I would add keepAutoSync field to ApplicationRollbackRequest proto and use that flag to disable or enable auto-sync on server side.

https://github.com/argoproj/argo-cd/blob/5abe863ea9a103a9ce3165f200e8b0f1b0828dcc/server/application/application.proto#L92-L97

[stale[bot]]

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.