Argo-cd: 1.2.0-rc2 Warning during secret diffing

[leominov]

It's all the same as #1923, but version is 1.2.0-rc2. Logs while refreshing application:

time="2019-08-23T12:33:19Z" level=info msg="Refreshing app status (normal refresh requested), level (2)" application=app-staging
W0823 12:33:19.405876       1 listers.go:77] can not retrieve list of objects using index : Index with name namespace does not exist
time="2019-08-23T12:33:19Z" level=info msg="Comparing app state (cluster: https://??.??.??.??, namespace: staging)" application=app-staging
time="2019-08-23T12:33:19Z" level=warning msg="Could not unmarshal to object of type /v1, Kind=Secret: illegal base64 data at input byte 0"
time="2019-08-23T12:33:19Z" level=warning msg="Could not unmarshal to object of type /v1, Kind=Secret: illegal base64 data at input byte 0"
time="2019-08-23T12:33:19Z" level=info msg="Skipping auto-sync: application status is Synced" application=app-staging
time="2019-08-23T12:33:19Z" level=info msg="Update successful" application=app-staging
time="2019-08-23T12:33:19Z" level=info msg="Reconciliation completed" application=app-staging fields.level=2 time_ms=571.727666

Correct: https://github.com/argoproj/argo-cd/blob/master/util/diff/diff.go#L390
Incorrect: https://github.com/argoproj/argo-cd/blob/v1.2.0-rc2/util/diff/diff.go#L390

Looks like it must be fixed before 1.3.

[alexec]

I don't understand "Looks like it must be fixed before 1.3.". Can you please clarify?

[leominov]

Ah, issue #1923 marked with 1.3 milestone, if I understood correctly.

[alexec]

@alexmt how about we back-port the fix (9c8ab50) to v1.2? It is small and low impact.

[alexmt]

I'm pretty confident it is safe to back-port. Change is very small.

[alexec]

Back-ported to v1.2

[alexmt]

@alexec , looks like it is still broken in 1.2:

$ argocd login cd.apps.argoproj.io  --grpc-web --sso
$ argocd app diff argo-cd                                                                                                                                                                

WARN[0001] Could not unmarshal to object of type /v1, Kind=Secret: illegal base64 data at input byte 8

[alexec]

Repro this. This is a warning, rather than an error.

apiVersion: v1
data:
  admin.password: +++++++++
  admin.passwordMtime: +++++++++
  dex.github.clientSecret: +++++++++
  server.secretkey: +++++++++
  tls.crt: +++++++++
  tls.key: +++++++++

$ echo -n '+++++++++' | base64 --decode | hexdump -C
00000000  fb ef be fb ef be                                 |......|
00000006

[alexec]

So there are 9 '+' symbols, not valid base64. But I'm not sure this is actually the problem.