Arduino-pro-ide: Use of non-standard macOS short cuts

[unknowndomain]

Describe the bug
The short cuts used are non standard.

Expected behavior
Examples:

• [x] Command + W = Close Window (fixed in https://github.com/eclipse-theia/theia/pull/6635)
• [x] Command + , = Preferences (fixed in https://github.com/eclipse-theia/theia/pull/6620)
• [x] Command + Shift + S = Save As (fixed in https://github.com/eclipse-theia/theia/pull/6620)

[sebromero]

More examples:

• [x] Command + O = Open File (fixed in https://github.com/eclipse-theia/theia/pull/6690)
• [ ] Command + "+" = Zoom in
• [x] Command + N = New File (fixed in https://github.com/eclipse-theia/theia/pull/6635)

[tigoe]

+1 to this issue. OS standard keyboard shortcuts are well-known, and should be respected. There are even some that are cross-OS that this system does not respect. I regard this as a bug.

The system should also respect as many of the original Arduino app keyboard shortcuts as possible, IMO, per issue #17

[jankeromnes]

FYI, I've updated Theia to use Command + , = Preferences by default on Mac OS: https://github.com/eclipse-theia/theia/pull/6620

In general, any keybindings that seem "standard" but are different to VS Code should be fixed in Theia.

On the other hand, any Arduino-specific keybindings (e.g. Command + U = Upload) can be defined in this project, by implementing a KeybindingContribution class with a registerKeybindings(keybindings: KeybindingRegistry): void method.

[jankeromnes]

Command + W = Close Window

In VS Code, this is different for each OS:

• Mac OS:
  
  
  
  • Command + W = Close Editor
  
  
  • Shift + Command + W = Close Window
  
  
• Linux (thanks for checking, @nisarhassan12!):
  
  
  
  • Ctrl + W = Close Editor
  
  
  • Ctrl + Q = Close Window
  
  
• Windows:
  
  
  
  • Ctrl + F4 = Close Editor
  
  
  • Ctrl + W = Close Window
  
  

Would these keybindings be acceptable in Arduino Pro too? (They may soon be the default in Theia.)

[jankeromnes]

Update: the majority of keybindings have been fixed upstream in Theia, so we should update Theia here whenever convenient.

Another thing that remains to be done here is Arduino-specific bindings like Cmd + U = Upload.

[jankeromnes]

With the latest Theia update and v0.0.3 release, this is now done. Hooray! Thanks all for your input.

Going forward, if you feel like a keybinding is missing, please open a dedicated issue for that particular keybinding.

Note that there is already #17 about supporting legacy Arduino IDE shortcuts like Cmd + U = Upload.