Arctos: Feature Request - unify transaction search

[dustymc]

Issue Documentation is http://handbook.arctosdb.org/how_to/How-to-Use-Issues-in-Arctos.html

Is your feature request related to a problem? Please describe.

See eg https://github.com/ArctosDB/arctos/issues/1965. This is a request to do the same thing in three places, adding this sort of information inevitably leads to wanting more query terms, then wanting to see query options in results, etc.; better access to data inspires requests for better ways of viewing data. All of that has to be done in multiple places, often with some variation in how it's done. It's a LOT of work and leads to inconsistent forms - loans can be searched by X, accessions cannot, accession results contain Y and loans do not, etc. etc.

Also there's currently no obvious way to get at things like "show me [agent's | collection's | this year's ] transactions" - everything is siloed by transaction type.

Describe what you're trying to accomplish
Make transaction forms easier to maintain and transaction data easier to access.

Describe the solution you'd like
One form that searches and displays search results for all transaction types. This would support all current functionality, but add the ability to specify/ignore transaction type.

Describe alternatives you've considered
Maintain way too much code, don't get cool functionality.

Additional context
This would simplify anything involving transaction search or search results. Creating, editing, etc. would not be effected; the unified form would just link on to eg edit loan.

Going next task - I know how to do this.

Priority
Plz help, AWG.

[ccicero]

I'm fine bumping this up in priority as well as #2947. It would help with reporting (permits, institutional, etc.).

[dustymc]

See https://github.com/ArctosDB/arctos/issues/2947 - make sure download and map works.

Closing https://github.com/ArctosDB/arctos/issues/2947 and carrying @ccicero 's priority over here.

[ebraker]

Agreed. This sounds really useful on all fronts.

[Jegelewicz]

YES

[campmlc]

Agree!

On Fri, Feb 19, 2021 at 3:14 PM Teresa Mayfield-Meyer <
[email protected]> wrote:

• [EXTERNAL]*

YES

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/ArctosDB/arctos/issues/3352#issuecomment-782400335,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADQ7JBG2WTJTAC47FEZSLNTS73PFBANCNFSM4WBEMJUA
.

[dustymc]

Please have a quick look at http://test.arctos.database.museum/transactionSearch.cfm

For now, I care only about

• The big-picture layout of the search page
• The big-picture layout of the results page

Please ignore the details for now, I'd just like to know if this is the right idea before I get much deeper.

• Minor details (moving things around, adding stuff, etc.) can come later, if necessary.
• The form is still very easy to break, try something else if your search fails.
• There's a low rowlimit, it'll be increased as this thing solidifies
• It currently handles nothing but loans.

I'll interpret silence as enthusiastic approval.

[Jegelewicz]

All of my comments would be related to the page layout. I think that all the stuff at the top are things that coulsd be a part of ANY transaction? FWIW, I think the stuff at the bottom should be at the top and the permit stuff should be clustered together in a block of some sort.

I searched loans for MSB:Mamm and got the max of 100 results, which was expected.

I may be wrong, but I think most permits are associated with accessions, so I failed at searching with any permit info since the form is only searching loans?

Agent Name selection needs to get checked against agents. Although I search for loans authorized by Joseph A. Cook and got the limit of 100, then one for loans authorized by Joe Cook and got the same results - it didn't appear that Arctos did its usual "yep this is an agent" after I entered the name though.

Search by loans due for MSB:Mamm between 2020-01-01 and 2020-12-31 returned two results - I'm guessing that's good given that data in test are stale.

Search by MSB:Mamm in house loans returned 79 - again probably reasonable.

Search by loan number "3012%" returned 36 - probs good

Search by part name = "skin, study" returned max of 100 - seems reasonable until I looked at the items for the first one, which only included "skin" - realized then that the comma in the part name is problematic....

Search on loaned part disposition = "transfer of custody" resulted in this:

An error occurred while processing this page!
Message: ERROR: missing FROM-clause entry for table "loan_srch_part" Position: 904
Detail:
Check the Arctos Handbook for more information on errors.

This message has been logged as 55DC3EDD-3E0D-4F7B-8232F94798E8CD9F Please contact us with any information that might help us to resolve this problem. For best results, include the error and a detail description of how it came to occur in the Issue.

same for "in collection"

Using the "Require media" widget got me the max results - probably makes sense. A review of the first one in the results show an attached document. I could see where adding the type of associated media might be useful (jpg vs txt...)

Hope that helps.

[dustymc]

I think that all the stuff at the top are things that coulsd be a part of ANY transaction?

Yes, that's why they're at the top and not in one of the specific blocks at the bottom. See "Also there's currently no obvious way to get at things like "show me [agent's | collection's | this year's ] transactions" - everything is siloed by transaction type." up ^^ yonder.

stuff at the bottom should be at the top

Easy to do - seems backwards to me, but I don't care.

permit stuff should be clustered together in a block of some sort.

Yes, it will be, "Minor details"

There are lots of permits on loans, but maybe not for "your" collections.

it didn't appear that Arctos did its usual "yep this is an agent" after I entered the name though.

EVERY agent search works like that. (Agent picks don't.)

realized then that the comma in the part name is problematic

Uhh - neat... So we can have values with characters that can't be differentiated from delimiters, or we can allow multiple values, but we can't (ish) do both. Not new anyway, I think....

loaned part disposition = "transfer of custody"

The form is still very easy to break, try something else if your search fails.

adding the type of associated media m

"Minor details...adding stuff" (I'm working on that now, not sure I'll use it for this since the injectable widget is more standardized - but there will be a download with media details - in JSON, because I can find no other sane way of representing complex data in a flat structure, if anyone wants to suggest a better way or just lodge a pre-complaint!)

Hope that helps.

Yes, thanks!

[campmlc]

I just tried searching accessions for MSB:Mamm, and I put transaction date

1. Got nothing. Tried 2017. No results. Tried 2017-01-10 to 2020-12-31.
   No results. I'd like to be able to find all accessions for a given year
   without having to type out the full Jan - December ISO dates.

On Tue, Feb 23, 2021 at 11:00 AM dustymc [e-mail] wrote:

• [EXTERNAL]*

I think that all the stuff at the top are things that coulsd be a part of
ANY transaction?

Yes, that's why they're at the top and not in one of the specific blocks
at the bottom. See "Also there's currently no obvious way to get at things
like "show me [agent's | collection's | this year's ] transactions" -
everything is siloed by transaction type." up ^^ yonder.

stuff at the bottom should be at the top

Easy to do - seems backwards to me, but I don't care.

permit stuff should be clustered together in a block of some sort.

Yes, it will be, "Minor details"

There are lots of permits on loans, but maybe not for "your" collections.

it didn't appear that Arctos did its usual "yep this is an agent" after I
entered the name though.

EVERY agent search works like that. (Agent picks don't.)

realized then that the comma in the part name is problematic

Uhh - neat... So we can have values with characters that can't be
differentiated from delimiters, or we can allow multiple values, but we
can't (ish) do both. Not new anyway, I think....

loaned part disposition = "transfer of custody"

The form is still very easy to break, try something else if your search
fails.

adding the type of associated media m

"Minor details...adding stuff" (I'm working on that now, not sure I'll use
it for this since the injectable widget is more standardized - but there
will be a download with media details - in JSON, because I can find no
other sane way of representing complex data in a flat structure, if anyone
wants to suggest a better way or just lodge a pre-complaint!)

Hope that helps.

Yes, thanks!

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/ArctosDB/arctos/issues/3352#issuecomment-784392102,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADQ7JBFJTVAFYGD5VRZ2MWTTAPUNRANCNFSM4WBEMJUA
.

[campmlc]

Also, when I click search after choosing those values (accn), the page says
"Loans" "0 results".

On Tue, Feb 23, 2021 at 11:35 AM Mariel Campbell [e-mail]
wrote:

I just tried searching accessions for MSB:Mamm, and I put transaction date

1. Got nothing. Tried 2017. No results. Tried 2017-01-10 to 2020-12-31.
   No results. I'd like to be able to find all accessions for a given year
   without having to type out the full Jan - December ISO dates.

On Tue, Feb 23, 2021 at 11:00 AM dustymc [e-mail] wrote:

• [EXTERNAL]*

I think that all the stuff at the top are things that coulsd be a part of
ANY transaction?

Yes, that's why they're at the top and not in one of the specific blocks
at the bottom. See "Also there's currently no obvious way to get at things
like "show me [agent's | collection's | this year's ] transactions" -
everything is siloed by transaction type." up ^^ yonder.

stuff at the bottom should be at the top

Easy to do - seems backwards to me, but I don't care.

permit stuff should be clustered together in a block of some sort.

Yes, it will be, "Minor details"

There are lots of permits on loans, but maybe not for "your" collections.

it didn't appear that Arctos did its usual "yep this is an agent" after I
entered the name though.

EVERY agent search works like that. (Agent picks don't.)

realized then that the comma in the part name is problematic

Uhh - neat... So we can have values with characters that can't be
differentiated from delimiters, or we can allow multiple values, but we
can't (ish) do both. Not new anyway, I think....

loaned part disposition = "transfer of custody"

The form is still very easy to break, try something else if your search
fails.

adding the type of associated media m

"Minor details...adding stuff" (I'm working on that now, not sure I'll
use it for this since the injectable widget is more standardized - but
there will be a download with media details - in JSON, because I can find
no other sane way of representing complex data in a flat structure, if
anyone wants to suggest a better way or just lodge a pre-complaint!)

Hope that helps.

Yes, thanks!

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/ArctosDB/arctos/issues/3352#issuecomment-784392102,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADQ7JBFJTVAFYGD5VRZ2MWTTAPUNRANCNFSM4WBEMJUA
.

[dustymc]

searching accessions

https://github.com/ArctosDB/arctos/issues/3352#issuecomment-784355603

[campmlc]

I tried searching "accn" and "MSB:Mamm: with no date entered - which we
used to be able to do in the old form (it returns 3050 accessions).
Got message below. I don't like a 100 result limit.
Query
Template: /transactionSearch.cfm:863
Execution Time: 37.7 ms
Record Count: 0
Cached: No
Lazy: No
SQL:
select
trans.transaction_id,
concatTransactionAgents(trans.transaction_id)::varchar as transagents,
concatTransactionPermits(trans.transaction_id)::varchar as transpermits,
concatTransactionProjects(trans.transaction_id)::varchar as transprojects,
concatTransactionMedia(trans.transaction_id)::varchar as transmedia,
trans.nature_of_material,
trans.trans_remarks,
trans.trans_date,
loan.loan_number,
loan.loan_type,
loan.loan_status,
loan.loan_instructions,
loan.loan_description,
to_char(loan.return_due_date,'YYYY-MM-DD') as return_due_date,
collection.guid_prefix,
count(distinct(loan_item.collection_object_id)) numberItems
from
trans inner join collection on trans.collection_id=collection.collection_id
inner join loan on trans.transaction_id=loan.transaction_id left outer join
loan_item on trans.transaction_id=loan_item.transaction_id
where
trans.transaction_type = 'accn' and
collection.guid_prefix in ('MSB:Mamm')
group by
trans.transaction_id,
concatTransactionAgents(trans.transaction_id),
concatTransactionPermits(trans.transaction_id),
concatTransactionProjects(trans.transaction_id),
trans.nature_of_material,
trans.trans_remarks,
trans.trans_date,
loan.loan_number,
loan.loan_type,
loan.loan_status,
loan.loan_instructions,
loan.loan_description,
to_char(loan.return_due_date,'YYYY-MM-DD'),
collection.guid_prefix
limit 10

On Tue, Feb 23, 2021 at 11:39 AM dustymc [e-mail] wrote:

• [EXTERNAL]*

searching accessions

3352 (comment)

https://github.com/ArctosDB/arctos/issues/3352#issuecomment-784355603

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/ArctosDB/arctos/issues/3352#issuecomment-784422919,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADQ7JBH246T6ZRBMJH6HAGLTAPY6XANCNFSM4WBEMJUA
.

[dustymc]

Please read https://github.com/ArctosDB/arctos/issues/3352#issuecomment-784355603

[campmlc]

I read that, and I couldn't figure out how that relates to what I am
seeing, other than that is just minor UI details?

On Tue, Feb 23, 2021 at 11:52 AM dustymc [e-mail] wrote:

• [EXTERNAL]*

Please read #3352 (comment)
https://github.com/ArctosDB/arctos/issues/3352#issuecomment-784355603

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/ArctosDB/arctos/issues/3352#issuecomment-784430715,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADQ7JBCMXAO26CZPLQ6GET3TAP2PNANCNFSM4WBEMJUA
.

[dustymc]

There's a low rowlimit, it'll be increased as this thing solidifies
It currently handles nothing but loans.

[dustymc]

permit stuff should be clustered

done

part disposition

fixed

media

now included

[Jegelewicz]

So we can have values with characters that can't be differentiated from delimiters, or we can allow multiple values, but we can't (ish) do both.

Can we use a different delimiter?

[dustymc]

different delimiter?

Comma-separators are baked pretty deep into the HTML Standard - we can certainly cheat, but that's very far from ideal. I don't think it's worth getting too crazy here, unless this form gets a lot of use that I don't know about.

[dustymc]

Built some indexes, rewrote some SQL, and optimized some functions, this did in fact eat my browser but not before I was able to get a screenshot:

If there are no layout change requests fairly soon I'll replicate what I have to accns and borrows.

[dustymc]

Added shipments - what else is missing?

[Jegelewicz]

I like that there is less scrolling, but

I really do think the stuff at the bottom will be used more than permit, shipment and media when searching. Most transaction searches are going to be for a specific loan or set of loans. I really think these two sections should be flipped:

[Jegelewicz]

You know what would be REALLY nifty? Once you select the transaction type, you are offered the options available for it.....

[dustymc]

two sections should be flipped:

Anyone else? It's pretty trivial to do that, we'll go with the silence==enthusiastic approval thing if nobody else has input....

Once you select the transaction type, you are offered the options available for it....

"Just javascript" probably, but I'm not sure I quite get it either. I think this will open up a lot of new use cases, and that would just hide two tiny panes or ?????????

[Jegelewicz]

It could be a page of sorts - first page is just "select a transaction type", then depending on selection you get the rest.

But that might be overkill...

[Jegelewicz]

One more nitpick - can each block be aligned to the top?

[dustymc]

first page is just "select a transaction type"

But much of the point is to NOT have that! What I've built supports "find foreign shipments" or "find Teresa's transactions" or "map all institution transactions for the last year" or .... Accessibility good, pigeonholes bad. (Unless you like pigeonholes, then you can specify transaction type.)

aligned

Yea, I'll get there....

[dustymc]

cleaned up the UI
shuffled cells
selecting transaction_type fires off some JS
loaned part takes list,=,%

@acdoll @jldunnum @campmlc @AJLinn @DerekSikes @krgomez @atrox10 @ccicero @cjconroy you all make lots of transactions (but not as many as Joseph Grinnell!)

http://test.arctos.database.museum/transactionSearch.cfm is a new all-transaction search form

only loans are functional; accession and borrow search forms exist, results will look much like loan (once loans are satisfactory)

This is only search and results - creation/editing forms won't change for now.

How could it be better?

[Jegelewicz]

selecting transaction_type fires off some JS

That's NIFTY! - Maybe a green box instead of yellow? A Bigger ask - HIDE instead of greying out?

How could it be better?

I think the results parameters block should be at the far left of that row.

Instead of "Parameters", just use "Terms"?

Nifty!

Also I like the navigation that helps avoid scrolling!

Suggest these look like .godo buttons - they are taking you to places where you can DO stuff. Or at least don't use the information icon?

[dustymc]

Maybe a green....

It's just CSS - I'll mess around with it, or you can do whatever and let me know (or just change the source).

You're using a developer browser of some sort, right? You can see/do something like this:

HIDE

That sets you up to...

• enter some accn stuff
• oh, wrong box, change transaction type to loan
• get frustrated because you're searching with parameters that you can no longer see or change

I could just blank-and-hide or something, but I think it's fairly useful to see the options, and it's not like a blank cell would save any screen real estate or etc. (It might under a different layout.)

should be at the far left of that row

I'll move it - I've got it set up so that's easy to do.

"Parameters", just use "Terms"?

wilco

like the navigation that helps avoid scrolling!

You can collapse panes as well.

buttons

We should have some site guidance. Those are hrefs, accessible design would probably/maybe have them being hrefs, we're of course not very consistent with that sort of thing (there are hrefs that act like buttons in this form....), we should be. Easy enough to tweak in any case, I'll see what it looks like.

don't use the information icon?

Those are newWinLocal - do we need a new href class?

Thanks!

[Jegelewicz]

don't use the information icon?

Those are newWinLocal - do we need a new href class?

These seem like the same thing I have on the Taxonomy page:

So maybe format them using that css? input.qutBtn

[dustymc]

/* quit: go somewhere else without saving any changes */

I suppose that's not WRONG, but I'm not crazy about scary-red button-link-thingees.

.lnkBtn ...

/* link; go somewhere not terribly scary */

is probably better, if we do in fact want buttons for links.

I changed one...

<a  href="/Loan.cfm?action=editLoan&transaction_id=#transaction_id#"><input type="button" class="lnkBtn" value="Edit Loan"></a>

but now it's _self - so new class-handler JS and...

<a class="newwin" href="/Loan.cfm?action=editLoan&transaction_id=#transaction_id#"><input type="button" class="lnkBtn" value="Edit Loan"></a>

is a href (so should work in screen readers and such) that looks like a button (because it seems maybe we like buttons??) that opens in a new window (because replacing my search results with an exploratory click is annoying).

Hard-reload to get the new JS.

Bueno?

[Jegelewicz]

Bueno - but I guess I should change the taxonomy stuff to be consistent...

[dustymc]

Buttons are there, queries work, nobody's complaining, I'm adding accns and borrows.

[campmlc]

Front end template looks good, but I'm running into a problem generating
reports.

On Wed, Feb 24, 2021 at 2:02 PM dustymc [e-mail] wrote:

• [EXTERNAL]*

Buttons are there, queries work, nobody's complaining, I'm adding accns
and borrows.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ArctosDB/arctos/issues/3352#issuecomment-785381992,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADQ7JBB5N47CIF7U7CP6UGLTAVSO5ANCNFSM4WBEMJUA
.

[dustymc]

generating reports.

I'm not sure what that means - there's no reporting in the new form (nor in the old that I can find). Should there be or ??????????????????????

[campmlc]

Just went to a loan using the new form and tried to print a loan invoice,
and got that error message. No idea if the problem is related to the search
form changes, but timing is suspicious.

On Wed, Feb 24, 2021, 4:11 PM dustymc [e-mail] wrote:

• [EXTERNAL]*

generating reports.

I'm not sure what that means - there's no reporting in the new form (nor
in the old that I can find). Should there be or ??????????????????????

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ArctosDB/arctos/issues/3352#issuecomment-785455145,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADQ7JBGCGVC6ZCLXWV4V6B3TAWBQXANCNFSM4WBEMJUA
.

[dustymc]

I can't break it - going next release.

[acdoll]

Late to the party as usual... but I think this looks and works awesome! I like the search's grid layout with the transaction terms on the top - the way it highlights the selected Transaction Type and greys out the others is (to use Teresa's terminology) _super_ nifty. The expandable dropdowns are a cool addition (though the Loan Status one is not expanding). CSV's download nicely. The Map Loan Shipments is awesome - if that's not a new feature I can't believe I haven't used it (I now see the button on regular Arctos, did that used to work?). That will be super helpful in showing use and reach of collections.
Nice work!

[dustymc]

Loan Status one is not expanding

Reload.

Thanks for the feedback!

[Jegelewicz]

expandable dropdowns

ARE super-nifty, it would be even niftier if I could close them when I decide I don't want multiples.... :-)

[dustymc]

if I could close

You can??

[Jegelewicz]

OK - seems like yesterday I couldn't...

NICE

[Jegelewicz]

Actually...BADASS this is a HUGE improvement!!!!

[dustymc]

yesterday

That was yesterday....

[Jegelewicz]

and all my troubles seemed so far away....

[dustymc]

"expandoSelect" is now sprinklable, sorta-green with a hopefully-better icon, and a bit niftier with small lists.

<span data-ctl="guid_prefix" class="ui-icon ui-icon-arrow-4-diag expandoSelect"></span>

after a select with an ID of guid_prefix should do magic anywhere in Arctos.