Arcade: x64 bits do not have strong name signing

[livarcocc]

In MSBuild, we have builds for x86 and x64. Our x64 build is available under a amd64 folder.

Our two executables that are binplaced for both x86 and x64 do not have a strong name signature in the amd64 folder.

One build that can be investigated is here: https://dev.azure.com/devdiv/DevDiv/_build/results?buildId=2479361

The files are properly authenticode signed but are missing strong name signature. And only the files under amd64.

cc @tmat

[tmat]

Looks like this might caused be caused by check for crossgen'd assemblies.

https://github.com/dotnet/arcade/blob/2e18c1c82f57a7bc4fe864f04ab11608efc9ad4f/src/Microsoft.DotNet.SignTool/src/ContentUtil.cs#L86

The tool likely confuses 64bit assembly with crossgen'd assembly, which we do not strong name sign.

[tmat]

@JohnTortugo @markwilkie

[livarcocc]

Please note that this is a blocker bug for 16.0 right now.

[markwilkie]

ACKing that it's a blocker. Let me know @JohnTortugo when you know more.

[tmat]

The log shows that the second msbuild.exe is indeed not queued for strong signing:

Not sure about the crossgen'd hypothesis now. The CorFlags of the .exe are 0x9, which means StrongNamed | ILOnly.

Does SignTool fail to remove Public Sign from 64bit assemblies?

[rainersigwald]

Might be a red herring: these files also don't have their .PDB file properly published in the build. I have assumed that that's not related, but since it's also only the x64 .exe's, figured it's worth mentioning in case it rings any bells.

[JohnTortugo]

Taking a look into this now.

[JohnTortugo]

Update:

Not able to repro the problem locally yet. I was able to build the repo and get some packages to test locally. In my local setup I see MSBuild being signed with. I'm trying to get the original unsigned files from the agent.

[3/25/2019 12:30:30 PM Informational] [xUnit.net 00:00:02.15]       File 'MSBuild.exe' TargetFramework='.NETFramework,Version=v4.7.2' Certificate='Microsoft400' StrongName='StrongName',
[3/25/2019 12:30:30 PM Informational] [xUnit.net 00:00:02.15]       File 'MSBuild.exe' TargetFramework='.NETFramework,Version=v4.7.2' Certificate='Microsoft400' StrongName='StrongName',
[3/25/2019 12:30:30 PM Informational] [xUnit.net 00:00:02.15]       File 'MSBuild.exe' TargetFramework='.NETFramework,Version=v4.7.2' Certificate='Microsoft400' StrongName='StrongName',

[tmat]

@JohnTortugo What was the issue?

[JohnTortugo]

Just updating to latest version of SN fixed the problem.