Apps-android-commons: Toolbar with share button is missing in Profile Activity

Created on 29 Dec 2020  路  6Comments  路  Source: commons-app/apps-android-commons

Summary:

After latest changes, toolbar with share button and back button of ProfileActivity disapeared. It should be added with back button.
Commons app version:
2.13.1
Screen-shots:
Screenshot of Current Master branch

Screenshot_2020-12-31-18-45-51-161_fr free nrw commons beta

screenshot of 2.13.2 (App at Google play store)

Screenshot_2021-01-01-17-48-39-397_fr free nrw commons

Would you like to work on the issue?
Yes
Please let us know whether you want to fix the issue by yourself. If not, anyone can get the issue assigned to them.
Yes

bug

Most helpful comment

Hey @nicolas-raoul , lets not assign this issue to @Prince-kushwaha since there are already 2 open PRs that requires changes. This issue is a release blocker so I will handle it ASAP.

All 6 comments

What do you suggest should appear in the toolbar of categoryDetailsActivity?
What do you suggest should appear in the toolbar of profileActivity?
Do you have any link to a document or discussion mentioning that an empty toolbar is a bad thing?
Thanks!

@nicolas-raoul view screenshot the screenshot

Ah, I see! That's a bug indeed, thanks!

Hey @nicolas-raoul , lets not assign this issue to @Prince-kushwaha since there are already 2 open PRs that requires changes. This issue is a release blocker so I will handle it ASAP.

is there anyone working on this issue? I would like to fix it.

Hi Roshan, this is yours :)

Was this page helpful?
0 / 5 - 0 ratings

Related issues

misaochan picture misaochan  路  4Comments

misaochan picture misaochan  路  4Comments

misaochan picture misaochan  路  3Comments

madhurgupta10 picture madhurgupta10  路  3Comments

Opsylac picture Opsylac  路  3Comments