Apps-android-commons: Use the primaryLightColor for dark theme in the app

[sivaraam]

There's a color specified in colors.xml with the name primaryLightColor. It looks like a nice complement to the primaryColor. While primaryColor seems suited for light theme, the light variant seems suited for the dark theme of the app.

So, I suggest using it in place of primaryColor for the dark theme. As a matter of fact, we could even consider using it for the icons in the bottom bar of the new UI. The current black-on-blackish has poor contrast.

[4D17Y4]

Hey, @sivaraam
I want to work on this.

I've changed the colors in Dark theme, although I was unable to get the difference in UI.

The second change was clear and here are the screenshot of the change.

Should I open a PR ?

[sivaraam]

Hi there 👋 Welcome to the project! This color change for dark theme is currently just a suggestion. We still need the opinion of others before we could make the change. Pinging a few people to get their opinion: @misaochan @neslihanturan @nicolas-raoul @madhurgupta10

[nicolas-raoul]

@sivaraam is right, at first better work on more well-defined issues rather than spend time implementing many details for possibly nothing.

Additionally, at first please focus on bugs as explained at https://github.com/commons-app/commons-app-documentation/blob/master/android/Volunteers-welcome!.md . Here is a URL that gives bugs that are great for newcomers to work on: https://github.com/commons-app/apps-android-commons/issues?utf8=%E2%9C%93&q=is%3Aopen+is%3Aissue+no%3Aassignee+-label%3Aassigned+-label%3Adebated+label%3Abug

Anyway, feel free to push your code to a branch of your repository and post a link here, that might help someone in the future :-)
Thanks a lot for your enthusiasm, and welcome to the team!

[4D17Y4]

Thx @nicolas-raoul ,
I'll go through them.

[misaochan]

The screenshot on the right looks better indeed to me. :)

(Also it seems the author names are completely hidden in dark mode, you can just see a tiny sliver of the "person" icon on the left, and you can't see the text at all.)