Apps-android-commons: Username remains visible even after logout

[madhurgupta10]

Summary:
Username (of the last logged in user) remains visible in the navigation drawer even after logout.

Steps to reproduce:
Login > Logout > Open Navigation Drawer

Commons app version:
betaDebug lastest master

[sivaraam]

Yeah. I observed this too.

[madhurgupta10]

@sivaraam I have noticed it for a while now, can someone confirm if it's intentional or a bug? My guess is that it is a bug.

[sivaraam]

can someone confirm if it's intentional or a bug?

I would have no doubt about this being a bug. Showing the username when a user is logged out is just misleading and has no obvious benefit to me. So, I don't think this is intentional. Correct me if I'm wrong.

[madhurgupta10]

can someone confirm if it's intentional or a bug?

I would have no doubt about this being a bug. Showing the username when a user is logged out is just misleading and has no obvious benefit to me. So, I don't think this is intentional. Correct me if I'm wrong.

I agree, the reason why I suspect it because it has been there unnoticed for so long.

Anyways, I would be happy to fix it!

[sivaraam]

Anyways, I would be happy to fix it!

Kindly do so! I'll assign this to you :)

[macgills]

this issue is irrelevant after #3649 is fixed, you shouldn't be able to see the navigation drawer after a logout.

[sivaraam]

this issue is irrelevant after #3649 is fixed, you shouldn't be able to see the navigation drawer after a logout.

Well, we would see it if we 'Skip' the log-in. I was thinking that was the reason behind this issue? 🤔

Note the Log-in button below the username indicating I'm not logged in.

[macgills]

I skipped the login after checking out #3649 and couldn't see my name in the drawer

[madhurgupta10]

@macgills If you click on username area then can you launch achievements activity?

[macgills]

Yes as I said in my comment on the PR where I asked you to open a separate issue

[madhurgupta10]

Yes as I said in my comment on the PR where I asked you to open a separate issue

@macgills I opened a new issue #3652 and it can be closed with #3648

[macgills]

Awesome