Apps-android-commons: Add tooltips for "depicts"

[misaochan]

Structured-data introduces a new concept to users, depicts. It would be good if we could add a tooltip to the "depicts" upload stage in the structured-data branch, to educate them on what it means (similar to what we currently have for title/desc).

[vvijayalakshmi21]

Hi @misaochan
When you say tooltips, do you refer to the one we see in Nearby (which upon clicking shows a text) or does it have to be a toast displayed when the user presses on the icon long?

[vvijayalakshmi21]

I would like to take this up after #3526 if thats okay?

[misaochan]

When you say tooltips, do you refer to the one we see in Nearby (which upon clicking shows a text)

Yes, I am referring to this one. Or the tooltips displayed in the title/desc section of the upload process.

I would like to take this up after #3526 if thats okay?

Sure! :)

[nicolas-raoul]

Here is the activity to which the tooltip should be added:

Here is how tooltips work in Step 1:

Maybe you could implement it like this:

[vvijayalakshmi21]

Thanks @nicolas-raoul
I will start looking into this.

[nicolas-raoul]

The text can be rather long, for instance the tooltip for "description" is 10 lines. I suggest:

_Select all things that your picture shows. For instance, if your picture shows a townhall in Smallville, then please select both "Townhall" and "Smallville". Try to be a specific as possible, for instance select "bulldog" instead of "dog" or "animal". Nearby items and recently used items may appear in the list, please only select the items that are actually visible in your picture._

[vvijayalakshmi21]

Hi @nicolas-raoul
I checked the code and I see that for step 1 the relevant java files are UploadMediaDetailAdapter and UploadMediaDetailFragment. Currently for depictions we have only DepictsFragment and no adapter file. Shall I create a new one similar to the uploadmedia adapter and proceed to make changes?

[macgills]

@vvijayalakshmi21 the code being located in the adapter is not relevant to this feature, adapters are just classes that feed data into views and on structured data all these input fields are a part of a list.

If you look at the master branch you will see a freewheeling textview outside the list in uploadMediaDetail and that is closer to what we want but is not such a terrific example either, it should really be following this advice

Raoul's mockup has the icon positioned outside of the EditText

So we don't even need to bother with TextInputLayout methods and can just use an ImageView + clickListener

If we were to use TextInpuLayout endIcon then I think it might overlap with the progress indication so if you think that looks better we might have to move the progress indication elsewhere

[misaochan]

I think keeping the progress indicator in the search field and having the tooltip icon outside the EditText as @nicolas-raoul suggests would be best.

[VibhorChinda]

Can i take this issue ?? @misaochan

[misaochan]

@vvijayalakshmi21 are you still interested in working on this?

[VibhorChinda]

Can I work on this ? @misaochan

[misaochan]

Let's give @vvijayalakshmi21 a bit more time to get back to us, if another week passes I think we can assign to you @VibhorChinda .

[vvijayalakshmi21]

@misaochan Sincere apologies for not getting back.
Please feel free to reassign to @VibhorChinda

[misaochan]

Thanks for getting back @vvijayalakshmi21 ! @VibhorChinda It is yours. :)

[robsonbbs]

Can I take this?

[nicolas-raoul]

@VibhorChinda Are you working on this? :-)

[VibhorChinda]

@nicolas-raoul Please feel free to re-assign the issue to @robsonbbs :)

[nicolas-raoul]

@robsonbbs It is yours, please let us know about your progress every few days at least, thanks :-)

[madisoncfallin]

Any chance I could take this over? :)

[nicolas-raoul]

@robsonbbs How is your progress so far? :-)

[gouri-panda]

@nicolas-raoul I want to work on this issue. If anyone isn't working on this ticket right now.

[gouri-panda]

If we were to use TextInpuLayout endIcon then I think it might overlap with the progress indication so if you think that looks better we might have to move the progress indication elsewhere

@nicolas-raoul As seàn suggested we can place the icon inside the TextInputEditText and on the side of progress bar like this.

[misaochan]

Oh wow, I just realized that this issue overlaps with #3757 , since it makes sense to include tooltips with the "depicts" title. @gouri-panda would you mind discussing this on #3757 ? Then I can close this issue.

[Roshan13046]

Is anyone still working on this issue?

[nicolas-raoul]

@Roshan13046 Double sorry: 1) For my late reply 2) Because we forgot to close this issue, the "tooltip" is already implemented. Please feel free to look at other issues, thanks a lot! :-)