Apps-android-commons: Logos in "About" screen are hardly viisble in dark theme
Summary:
The logos in About screen were recently changed in #3444. But the new logos are hardly visible in dark theme. We should show appropriate logos which are visible well in dark theme.
Screen-shots:
sivaraam
All 12 comments
guess this issue has been cleared @sivaraam
if so could you please close the issue @nicolas-raoul
bharathbiju
on 23 Mar 2020
guess this issue has been cleared @sivaraam
if so could you please close the issue @nicolas-raoul
@bharathbiju I don't think this issue is solved yet!
madhurgupta10
on 25 Mar 2020
Pinging @misaochan and @nicolas-raoul for suggestions!
madhurgupta10
on 26 Mar 2020
Change them to white? Are these vectors? You can change 1 line to get them to be white, add that as a new icon and then use attributes set in light/dark theme to switch between the images, there are some examples for colors already there
macgills
on 26 Mar 2020
Change them to white?
Changing color is nice. But changing it to white might make the icons stand out in the black background and they might possibly attract attention away from the text (which seems to be greyish in color). It would be nice if we could use a different color other than white.
But it seems, both Facebook and GitHub are against changing colors. So, I think it's better if we just use the light colored icons provided by them as it is.
- GitHub has a light colored icons in it's mark logo zip
- Facebook has both grey and white icons but I think we can just go with white to be consistent.
- For the globe icon we use Material public icon and we can download a white colored icon from their website.
sivaraam
on 26 Mar 2020
How about keeping the color of logos black and adding a small white circle in the background similar to the Github Android App Icon.
madhurgupta10
on 27 Mar 2020
Use white, I think we are all in agreement.
Now who wants the ticket assigned?
macgills
on 27 Mar 2020
@macgills The issue seems to be perfect for first-time contributors.
madhurgupta10
on 27 Mar 2020
hello @macgills @nicolas-raoul I would like to handle this issue.
isnirp
on 27 Mar 2020
@isnirp I've assigned this to you. Let us know how you get on. Feel free to ask for any help, if need be. :)
sivaraam
on 27 Mar 2020
@sivaraam it's resolved. created an attr for images present in about. do I do a PR?
isnirp
on 27 Mar 2020
@isnirp That's great!
do I do a PR?
Sure, feel free to open a PR :)
sivaraam
on 27 Mar 2020
Related issues
madhurgupta10
路
3Comments
whym
路
3Comments
4D17Y4
路
3Comments
neslihanturan
路
3Comments
nicolas-raoul
路
3Comments
Most helpful comment
Change them to white? Are these vectors? You can change 1 line to get them to be white, add that as a new icon and then use attributes set in light/dark theme to switch between the images, there are some examples for colors already there