Apps-android-commons: Replace static summary in custom author name with actual value

Created on 17 Mar 2020  路  9Comments  路  Source: commons-app/apps-android-commons

Summary:

Continuing the discussion from thread

Currently, a static summary is set which is somewhat repetition of the above switchpref

76859067-db11a980-6858-11ea-9898-1b8e9bf5d382

According to me, it would be better to show Not Set or the actual value.
Screenshot_1584450599

Screenshot_1584450593

Would you like to work on the issue?
Yes, I already have a PR for this

Most helpful comment

I'm not sure the issue ever reached a consensus. If memory serves, the consensus was forming around keeping the two options as it is and just fixing the summary issue. But then the discussion stopped.

In case it's not clear, I pointed to that issue just to ensure you close that too when the PR #3537 gets merged. Nothing else 馃檪

All 9 comments

Pinging @misaochan @macgills for inputs.

I am in favour of it and androidx supports the functionality well

I have linked my PR and we can Merge/Close as per the discussion. :)

Just wondering, isn't this a duplicate of #3415? :thinking:

Absolutely but after skimming and scrolling to the end what did that ticket end up being about?

I'm not sure the issue ever reached a consensus. If memory serves, the consensus was forming around keeping the two options as it is and just fixing the summary issue. But then the discussion stopped.

In case it's not clear, I pointed to that issue just to ensure you close that too when the PR #3537 gets merged. Nothing else 馃檪

superb

@misaochan with your approval of this feature I will merge the linked PR

Looks good to me, thanks @madhurgupta10 and @macgills . :)

Was this page helpful?
0 / 5 - 0 ratings