Apps-android-commons: "Nearby Place found" despite already Nearby upload

[nicolas-raoul]

Via Nearby, I took a pic of https://www.wikidata.org/wiki/Q21019339 (日本福音ルーテル社団)

Problem: While entering title, it asked me whether it is a pic of https://www.wikidata.org/wiki/Q11386485 (Oreno Hamburg Yamamoto) :

I said no, obviously.

Sad result: pic is linked from no Wikidata item.
https://commons.m.wikimedia.org/wiki/File%3A%E6%97%A5%E6%9C%AC%E7%A6%8F%E9%9F%B3%E3%83%AB%E3%83%BC%E3%83%86%E3%83%AB%E7%A4%BE%E5%9B%A3.jpg

Latest alpha (2.12.3.566~a6d2523)

[madhurgupta10]

@nicolas-raoul Can I work on this issue
?

[nicolas-raoul]

@madhurgupta10 Sure, thanks! :-)

[nicolas-raoul]

Just to make sure I was explicit:

When I come from Nearby, I already have a Wikidata item QID number associated, so the app should not display any "Nearby Place Found". Actually it should not even perform the latitude/longitude retrieval and Wikidata request, as they take time for nothing in that case.

:-)

[misaochan]

I agree, the solution would be to simply disable the search if the user is doing a direct Nearby upload.

[nicolas-raoul]

The issue is still present, I uploaded the picture below via Nearby, and P18 did not get filled: https://commons.wikimedia.org/wiki/File:Embassy_of_Slovakia,_Tokyo_2.jpg

Actually my last 5 Nearby uploads have all failed to get P18, this bug is particularly penalizing in dense cities.

[macgills]

@madhurgupta10 I can take this issue if your are busy

[madhurgupta10]

@macgills Sure, thank you!

[Pratham2305]

@nicolas-raoul @madhurgupta10 I am able to reproduce this one on the latest master, Can I work on this?

[nicolas-raoul]

@Pratham2305 It is yours, thanks! :-)
The best would probably be to not search nearby items (and thus not show the popup) if the upload is already coming from the Nearby feature.

[misaochan]

Did #3799 not fix this?

Edit: Ah, I see it was closed instead of merged. Might be worth looking at it for clues @Pratham2305 . :)

[nicolas-raoul]

I experienced this bug two days ago, so I guess it somehow is still around.
Ah, good find, this PR should be a good source of inspiration :-)