Apps-android-commons: Do not display pins at all when "Needs Photo" is selected?

[misaochan]

Currently, when "Needs Photo" filter is selected, we still display the pins of Wikidata items that DON'T need photos, except that they are transparent. However, this seems to confuse users - for instance, one user thought that the transparent pins were the items that "don't exist" (which kind of makes sense!).

While the current UI does look very nice, I wonder if it might be best to:

1. Do not display the pins of items that don't "need photos" at all, when that filter is selected. When the user de-selects that filter, the current system of green pins is fine.
2. Instead, display the pins of items that don't "exist" as transparent

What do you think @neslihanturan @VojtechDostal @nicolas-raoul ?

[VojtechDostal]

I must say I was confused when I first saw this but I got used to it. If you don't mind, I'd be in favour of spmehow hiding the pins altogether which do not comply with the chosen criteria.

[kbhardwaj123]

This does look a bit confusing i think we should remove those pins, moreover due to that border they look grey rather than transparent, if everyone is in favour of this i would interested to work on it

[nicolas-raoul]

I agree with @VojtechDostal too. Conditions are here to reduce the number of pins. Having different colors is not needed, I think.

@kbhardwaj123 looking forward to your pull request :-)
@misaochan or do you prefer another solution?

[misaochan]

Yes, that solution sounds fine, just make sure they are displayed when the user selects to view them. :) Basically, I think the way the pins are now are fine when the user de-selects "Need photos" (two types of pins, of different colors), but when the user selects "Need photos", the extra pins should be removed.

[neslihanturan]

Hey, I was testing #3335 . Currently filtered out pins are removed at all. But it does not seems clear when the user filtered out everything:

I think our current implementation is more clear.

[misaochan]

Sorry, I'm confused, how is it possible to filter out everything? If they select "Needs Photos" then it should only filter out the pins that have photos, right? Or are you referring to the place type?

[neslihanturan]

When we filter by place type, we can select a type which is not there. Ie. parks.

[misaochan]

I think for place type that would be an expected behaviour - in other maps (e.g. Google Maps or booking.com), if I am searching for something and I make my filters too restrictive and I see nothing, I think I would intuitively understand that I have filtered out all the possibilities. Perhaps however it could be useful to have an indicator that the place type filter is active, in the upper panel.