Apps-android-commons: For an item that already has a P18, do not add another one

[nicolas-raoul]

The Nearby activity now also shows Wikidata items that have a P18 image. That's great.

But when the user choose to add an image based on this item, the image should not be added as an another P18.
Why? Because a Wikidata item should only have one P18 image. By the way, the selection of the most representative image is sometimes the result of a community conversation, so replacing the existing image is probably not a good idea either.

The item's information can still be used to propose categories/etc, though, so it makes sense to keep the + even for items that already have a P18.

I tag this as a bug because I have to clean up manually behind haha.

[misaochan]

Ah, thanks for bringing this up. I agree, we should remove the last step (adding the item to p18) for items that already have a p18 (i.e. does not "need photos"). @ashishkumar468

[nicolas-raoul]

I don't think that should block any imminent release, though.
I personally review all P18 manually and fix all such cases, it only takes a few minutes per week.
It is an interesting task for a newcomer, I think.

[misaochan]

Thanks @nicolas-raoul . :) 2.13 is a long time away, but I will make a note that it is optional still.

[ghost]

@misaochan can I work on this issue?

[misaochan]

@vishakha-a Sure, let us know how it goes. :)

[misaochan]

@vishakha-a How are things going?

[CodeMonk263]

Can i work on this issue

[ghost]

No, no
I am trying to figure out what to do

On Sun, 23 Feb 2020 at 12:59, Shaurya Vijayvargiya [e-mail]
wrote:

Can i work on this issue

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/commons-app/apps-android-commons/issues/3333?email_source=notifications&email_token=AKE773SE5RZ36FXUZRHRAOTREIQURA5CNFSM4KJREYA2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMVTV3Y#issuecomment-590035695,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKE773UQLGYCN7U3BQVXJTTREIQURANCNFSM4KJREYAQ
.

[misaochan]

@vishakha-a If you let us know where exactly you are stuck and what you have tried so far, we might be able to help you.

[nicolas-raoul]

@vishakha-a Yes, at least every two days please let us:

• What you tried
• What did not work
• What worked
• What step you are planning to start next

Thanks :-)

[nicolas-raoul]

@vishakha-a Please share your progress, thanks!
Otherwise you might have to let someone else take the issue.
Thanks for your understanding :-)

[ghost]

Hey, yes you can take the issue. Sincere apologies for holding it back. I
am unable to understand the issue I probably need to learn a lot before I
can make any contributions.

On Fri, 6 Mar 2020 at 11:49, Nicolas Raoul [e-mail] wrote:

@vishakha-a https://github.com/vishakha-a Please share your progress,
thanks!
Otherwise you might have to let someone else take the issue.
Thanks for your understanding :-)

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/commons-app/apps-android-commons/issues/3333?email_source=notifications&email_token=AKE773UGKJ3EKWT4LHHOTKDRGCIXJA5CNFSM4KJREYA2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOAGZCY#issuecomment-595618955,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKE773S4DK7XEGTOBTJOCNTRGCIXJANCNFSM4KJREYAQ
.