Apps-android-commons: "No depictions selected" despite one selected

[nicolas-raoul]

@vanshikaarora

[vanshikaarora]

I'll look into this

[nicolas-raoul]

This is still happening, did you try to reproduce it and fix it?

[vanshikaarora]

@nicolas-raoul I tried to work upon this. Actually the Issue is, when you click on the checkbox it shows not item selected however when you click on the depiction item(the text or description) it works perfectly.

The Issuue is it considers only the text and description item in it's root view and not the checkbox. I am still not able to figure out why the entire layout_upload_depicts_item.xml as it's root view

[nicolas-raoul]

Are the correct "Q___" items passed to the method that uploads depictions?
If yes, how about using checking whether the list of items is empty, rather than checking the UI? :-)

[vanshikaarora]

@nicolas-raoul yes the "Q____" items are passed when you click on the label or description nut are empty on clicking the check box

[nicolas-raoul]

I am sure that pressing the checkbox works for _categories_. Please compare the two in debug mode, thanks :-)

[vanshikaarora]

@nicolas-raoul I have fixed the issue here

Please check :-)

[nicolas-raoul]

Seems to work well now, thanks 🙂

On Sat, 3 Aug 2019, 20:45 Vanshika Arora, [e-mail] wrote:

@nicolas-raoul https://github.com/nicolas-raoul I have fixed the issue
here
https://github.com/commons-app/apps-android-commons/pull/2970/commits/39834fb61faeacc0fe0c3265cceb74de54030a44

Please check :-)

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/commons-app/apps-android-commons/issues/3076?email_source=notifications&email_token=AAAYKBQUX42A2RZALAO6IQDQCVVVJA5CNFSM4IENOZB2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3PM6AI#issuecomment-517918465,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAYKBTITMG36VSF7LZQGPTQCVVVJANCNFSM4IENOZBQ
.