Apps-android-commons: Option to Remove a new language description while uploading

[madhurgupta10]

Summary:

Sometimes, a user might accidentally hit the "+" when uploading a photo, there is no option to remove it. We should add a "-" so that the user can remove it.

Steps to reproduce:
Upload a new photo, hit the + button many times in Step 1, then try to remove not needed ones.

Screen-shots:

Would you like to work on the issue?
Yes

[maskaravivek]

Apart from this, the user should not be allowed to add the same language twice.

[madhurgupta10]

@maskaravivek Good Point, I would implement that as well :)

[domdomegg]

@maskaravivek Good Point, I would implement that as well :)

I'm not sure how tightly bound this code is, but if you are it might be best to do them as separate PRs so they're easier to review.

[madhurgupta10]

@domdomegg Cool, I will make separate issue for it :)

[maxbetton]

Hello, I see the issue is available. Can I take it ?

[madhurgupta10]

@maxbetton Sure go ahead!

[madhurgupta10]

Feel free to refer https://github.com/commons-app/apps-android-commons/pull/3504#issuecomment-600801773 for UI

[maxbetton]

Thank you. For sure, I saw it :)

[maxbetton]

Just to be sure, are we OK with that?

[madhurgupta10]

@maxbetton My Bad, I see that some comments got hidden and the UI which was actually finalised is this https://github.com/commons-app/apps-android-commons/pull/3504#issuecomment-619364827

[maxbetton]

I have open the PR #4206 for this issue;

[neslihanturan]

The PR #4206 was working, however it had irrelevant changes, thus we couldn't merge it. Anyone else can implement is in the same way and this issue should be solved :)

[Ayan-10]

@neslihanturan Can I do this?

[madhurgupta10]

@Ayan-10 feel free to create a PR for this issue!

[Ayan-10]

@madhurgupta10 can I use

this remove icon. Instead of X icon?

[madhurgupta10]

@Ayan-10 I would prefer the "x" but lets discuss it with @neslihanturan

[Ayan-10]

@neslihanturan Can you please give your opinion on this? My code is ready for PR. I am waiting for your response.

[madhurgupta10]

@Ayan-10 You can start working on this, the icon can be changed later easily if needed.

[misaochan]

I would strongly prefer an "x" as well, it's much more commonly used.

[Ayan-10]

@madhurgupta10 @misaochan Thank you for your response. I create the PR.

[neslihanturan]

I would say "x" too. Also please consider the previous PR implementation since it was mostly working in general.

[Ayan-10]

I would say "x" too. Also please consider the previous PR implementation since it was mostly working in general.

@neslihanturan I already made a PR. Please have a look at #4406