Apps-android-commons: Collection of device's essential information when user want to share feedback

[madhurgupta10]

Summary:
When a user wants to share some feedback, the current scenario does not include the device name, model number, network type, etc.
Automatically adding this to the email template would help the team to address the feedback precisely.

Steps to reproduce:
Open the app < hamburger menu < Feedback

Would you like to work on the issue?
Yes, I want to work on this issue :)

[madhurgupta10]

@nicolas-raoul Should I keep the support information same for all languages?

[nicolas-raoul]

@madhurgupta10 Localization would be a good thing, I would say.

[madhurgupta10]

@nicolas-raoul Cool, well in that case shall I just create strings in res file for English and translateWiki would take care of the rest, right?

[nicolas-raoul]

Yes, that's it :-)

On Thu, Feb 21, 2019 at 4:53 PM Madhur Gupta [e-mail]
wrote:

@nicolas-raoul https://github.com/nicolas-raoul Cool, well in that case
shall I just create strings in res file for English and translate would
take care of the rest, right?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/commons-app/apps-android-commons/issues/2494#issuecomment-465897857,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAGFBvxQO1JfCrYvKphvpUd4zHLOd2tnks5vPlCMgaJpZM4bFg7g
.

[madhurgupta10]

@nicolas-raoul Done, shall I add anything else?

[nicolas-raoul]

Is that how it will appear to English-language users?
If yes, why not the friendlier "API level" instead of "API_LEVEL"? Same for
the others.

Also, since "App version" is in the body, we can remove it from the email
title :-)

Thanks!

On Thu, Feb 21, 2019 at 6:10 PM Madhur Gupta [e-mail]
wrote:

@nicolas-raoul https://github.com/nicolas-raoul Done, shall I add
anything else?
[image: screenshot_20190221-143825]
https://user-images.githubusercontent.com/30932899/53156965-89133b80-35e6-11e9-9bb3-0607567bc04a.png

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/commons-app/apps-android-commons/issues/2494#issuecomment-465920277,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAGFBs-xmxXsJGMmfV9BN2b1uaZm-5ztks5vPmJ4gaJpZM4bFg7g
.

[madhurgupta10]

@nicolas-raoul Sure, I will make the changes

[madhurgupta10]

@nicolas-raoul I think keeping the app version in the title would be better than the body, but I can do it, either way, let me know :)

[nicolas-raoul]

I let you choose what you think is best :-)

[madhurgupta10]

@nicolas-raoul PR is ready :)

[maskaravivek]

@nicolas-raoul will localising these strings be useful? Most of the people who are part of the commons and commons private Google groups understand English whereas if these meta deta come in any of the ~50-100 supported languages then it might be difficult to interpret.

As these strings would be seen by one who is reading the feedback/logs IMO it would be better not to localise it.

My understanding might be wrong. Please correct me if I am missing something. :)

[nicolas-raoul]

From the perspective of a non-technical non-English-language person who wants to send feedback about the app, it might be scary to have obscure codes and words in a language you do not understand added to your feedback.

For us English-speaking developers the content sounds obvious, but imagine you want to send feedback about something and this text gets attached to your email:

الشركة المصنعة 98942367423962
الجهاز 460234530942
موديل 49386243968

Would you press Send? Would you not be at least a little bit tempted to erase it or not send the email at all?
That being said, I am also OK with not localizing that part.

[madhurgupta10]

@nicolas-raoul I agree this will be scary, as the person doesn't know what information is attached to the email. What if we replace --Support-Info-- with something that explains the information attached below like Down below we have added some information which will help developers to help you better, you don't need to change anything below

[nicolas-raoul]

@madhurgupta10 I think Technical information would be clear enough :-)

[madhurgupta10]

@nicolas-raoul @maskaravivek Okay 👍 I will make the changes, thanks for the discussion :)