Apps-android-commons: Night mode: Tabs

[domdomegg]

Summary:

Tabs are inconsistent in how they are styled. I'm okay with MainActivity being different but Search and Category tabs should definitely look the same.

Should also probably standardise across non-night mode too.

Tabs are used in (edit this list if I've forgotten some):

• MainActivity (Contributions/Nearby)
• SearchActivity (Media/Categories)
• Category page (Media/Subcategories/Parent categories)
• Bookmarks page (Pictures/Locations)

Screen-shots:

| MainActivity | SearchActivity | Category |
| - | - | - |
| | | |

[borisenkotim]

Hey, I would like to work on this issue.

[domdomegg]

Assigned to @borisenkotim

[domdomegg]

It's obviously up for debate, but I think the best look is having them look like part of the toolbar (as they are in the Category screenshot above).

[domdomegg]

Or white on black is quite good. Basically just not something with a white background.

[neslihanturan]

Actually my favorite here is first (MainActivity) style, _whoever create a PR please share 3 screenshots for dark theme like above and 3 for light theme._

But I think this PR requires discussion, so please do not start implementation before we find our path.

[borisenkotim]

Working on it.

[borisenkotim]

Thus far I made this change to the bookmarks bar. I think it looks better. Now it is the same as category tabs. The Main activity (home) as been left alone. I'm gonna try making the searchActivity section the same now.

[domdomegg]

Looks good. I can have a look over the code so far if you'd like - push your changes to your fork on Github and start a pull request with [WIP] in the title (work in progress).

[borisenkotim]

Before

After

Here is how the searchactivity page looks now.